Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(vee-eight-4.9) Replace more deprecated V8 API usage #5204

Closed
wants to merge 4 commits into from
Closed

(vee-eight-4.9) Replace more deprecated V8 API usage #5204

wants to merge 4 commits into from

Conversation

ofrobots
Copy link
Contributor

Continuing from #5159, this PR replaces deprecated uses of SetAccessor and most uses of SetWeak on the vee-eight-4.9 branch.

The use of SetWeak in src/node_buffer.cc is more involved because it expects to get a handle to the weak object in the weak callback. I need to understand the buffer code a bit more before attempting to change that.

EDIT: the original change for SetWeak usage in node_contextify was flawed. I have removed that.

Remaining work:

See also: #4869
R=@bnoordhuis , @targos
/cc @nodejs/v8

@ofrobots ofrobots added the v8 engine Issues and PRs related to the V8 dependency. label Feb 12, 2016
@ofrobots
src: replace usage of deprecated SetAccessor
23589ac
@ofrobots
src: fix deprecated SetWeak usage in base-object
14ba959
@ofrobots
buffer: cleanup CallbackInfo
34bf1da 
Dynamic checks that CallbackInfo holds an ArrayBuffer handle can be
converted into compiler enforced checks. Removed unused code, and
other minor cleanup.
bnoordhuis
bnoordhuis reviewed Feb 21, 2016
View reviewed changes
src/node_buffer.cc
if (object->ByteLength() != 0)
CHECK_NE(data, nullptr);

object->SetAlignedPointerInInternalField(0, data);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nicer to make the field index a class constant.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we maybe make a comment in the header that the first internal field is reserved by node? Since switching to using array buffer I've been writing experimental modules that also make use of these fields.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. In the light of wanting a comment in the header, I chose to make it a header constant rather than class constant. 8be49858fab.

@bnoordhuis
Copy link
Member

LGTM with a suggestion.

@indutny
Copy link
Member

indutny commented Feb 21, 2016

LGTM

@ofrobots
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/1721/

Updating the use of SetWeak in node_contextify.cc might be a non-trivial amount of work. Let's do it in a follow-on PR. I haven't looked at NewExternal in string_bytes.cc yet.

@ofrobots ofrobots mentioned this pull request Feb 23, 2016
Closed
4 tasks
@ofrobots
buffer: replace deprecated SetWeak usage
dcecbde 
Old style SetWeak is now deprecated, and weakness now works like
phantom references. This means we no longer have a reference to the
object in the weak callback. We use a kInternalFields style weak
callback which provides us with the contents of 2 internal fields
where we can squirrel away the native buffer pointer.

We can no longer neuter the buffer in the weak callback, but that
should be unnecessary as the object is going to be GC'd during the
current gc cycle.
@ofrobots
Copy link
Contributor Author

Second CI (also includes follow-on #5392): https://ci.nodejs.org/job/node-test-pull-request/1749/

ofrobots added a commit that referenced this pull request Feb 25, 2016
@ofrobots
src: replace usage of deprecated SetAccessor
2e6934c 
PR-URL: #5204
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
ofrobots added a commit that referenced this pull request Feb 25, 2016
@ofrobots
src: fix deprecated SetWeak usage in base-object
0aaacb5 
PR-URL: #5204
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
ofrobots added a commit that referenced this pull request Feb 25, 2016
@ofrobots
buffer: cleanup CallbackInfo
a942d56 
Dynamic checks that CallbackInfo holds an ArrayBuffer handle can be
converted into compiler enforced checks. Removed unused code, and
other minor cleanup.

PR-URL: #5204
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
ofrobots added a commit that referenced this pull request Feb 25, 2016
@ofrobots
buffer: replace deprecated SetWeak usage
7a863af 
Old style SetWeak is now deprecated, and weakness now works like
phantom references. This means we no longer have a reference to the
object in the weak callback. We use a kInternalFields style weak
callback which provides us with the contents of 2 internal fields
where we can squirrel away the native buffer pointer.

We can no longer neuter the buffer in the weak callback, but that
should be unnecessary as the object is going to be GC'd during the
current gc cycle.

PR-URL: #5204
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
@ofrobots
Copy link
Contributor Author

Landed as d47a982...7a863af.

@ofrobots ofrobots closed this Feb 25, 2016
@ofrobots ofrobots mentioned this pull request Feb 26, 2016
Closed
4 tasks
ofrobots added a commit to ofrobots/node that referenced this pull request Mar 1, 2016
@ofrobots
src: replace usage of deprecated SetAccessor
81238bb 
PR-URL: nodejs#5204
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
ofrobots added a commit to ofrobots/node that referenced this pull request Mar 1, 2016
@ofrobots
src: fix deprecated SetWeak usage in base-object
502568e 
PR-URL: nodejs#5204
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
ofrobots added a commit to ofrobots/node that referenced this pull request Mar 3, 2016
@ofrobots
src: replace usage of deprecated SetAccessor
ea4f27c 
PR-URL: nodejs#5204
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
ofrobots added a commit to ofrobots/node that referenced this pull request Mar 3, 2016
@ofrobots
src: fix deprecated SetWeak usage in base-object
bdbd3a2 
PR-URL: nodejs#5204
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
ofrobots added a commit to ofrobots/node that referenced this pull request Mar 3, 2016
@ofrobots
buffer: cleanup CallbackInfo
8d6ae3b 
Dynamic checks that CallbackInfo holds an ArrayBuffer handle can be
converted into compiler enforced checks. Removed unused code, and
other minor cleanup.

PR-URL: nodejs#5204
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
ofrobots added a commit to ofrobots/node that referenced this pull request Mar 3, 2016
@ofrobots
buffer: replace deprecated SetWeak usage
9e5cd28 
Old style SetWeak is now deprecated, and weakness now works like
phantom references. This means we no longer have a reference to the
object in the weak callback. We use a kInternalFields style weak
callback which provides us with the contents of 2 internal fields
where we can squirrel away the native buffer pointer.

We can no longer neuter the buffer in the weak callback, but that
should be unnecessary as the object is going to be GC'd during the
current gc cycle.

PR-URL: nodejs#5204
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
ofrobots added a commit that referenced this pull request Mar 4, 2016
@ofrobots
src: replace usage of deprecated SetAccessor
c1649a7 
PR-URL: #5204
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
ofrobots added a commit that referenced this pull request Mar 4, 2016
@ofrobots
src: fix deprecated SetWeak usage in base-object
a45e1f9 
PR-URL: #5204
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
ofrobots added a commit that referenced this pull request Mar 4, 2016
@ofrobots
buffer: cleanup CallbackInfo
34aac23 
Dynamic checks that CallbackInfo holds an ArrayBuffer handle can be
converted into compiler enforced checks. Removed unused code, and
other minor cleanup.

PR-URL: #5204
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
ofrobots added a commit that referenced this pull request Mar 4, 2016
@ofrobots
buffer: replace deprecated SetWeak usage
ebbbc5a 
Old style SetWeak is now deprecated, and weakness now works like
phantom references. This means we no longer have a reference to the
object in the weak callback. We use a kInternalFields style weak
callback which provides us with the contents of 2 internal fields
where we can squirrel away the native buffer pointer.

We can no longer neuter the buffer in the weak callback, but that
should be unnecessary as the object is going to be GC'd during the
current gc cycle.

PR-URL: #5204
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
@ofrobots ofrobots mentioned this pull request Mar 17, 2016
Closed
3 tasks
@lovell lovell mentioned this pull request May 18, 2016
Closed
addaleax added a commit to addaleax/node that referenced this pull request Jan 13, 2019
@addaleax
src: remove outdated Neuter() call in node_buffer.cc
98da4cc 
This call was introduced in 827ee49 to avoid a crash in a
later `Neuter()` call that has later been removed in ebbbc5a,
rendering the original call unnecessary.

Refs: nodejs#3624
Refs: nodejs#5204
@addaleax addaleax mentioned this pull request Jan 13, 2019
Closed
2 tasks
addaleax added a commit that referenced this pull request Jan 21, 2019
@addaleax
src: remove outdated Neuter() call in node_buffer.cc
30f4568 
This call was introduced in 827ee49 to avoid a crash in a
later `Neuter()` call that has later been removed in ebbbc5a,
rendering the original call unnecessary.

Refs: #3624
Refs: #5204

PR-URL: #25479
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
targos pushed a commit that referenced this pull request Jan 24, 2019
@addaleax @targos
src: remove outdated Neuter() call in node_buffer.cc
dbecc82 
This call was introduced in 827ee49 to avoid a crash in a
later `Neuter()` call that has later been removed in ebbbc5a,
rendering the original call unnecessary.

Refs: #3624
Refs: #5204

PR-URL: #25479
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
@addaleax @BethGriggs
src: remove outdated Neuter() call in node_buffer.cc
1d2d3f3 
This call was introduced in 827ee49 to avoid a crash in a
later `Neuter()` call that has later been removed in ebbbc5a,
rendering the original call unnecessary.

Refs: #3624
Refs: #5204

PR-URL: #25479
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@addaleax @BethGriggs
src: remove outdated Neuter() call in node_buffer.cc
f71c55b 
This call was introduced in 827ee49 to avoid a crash in a
later `Neuter()` call that has later been removed in ebbbc5a,
rendering the original call unnecessary.

Refs: #3624
Refs: #5204

PR-URL: #25479
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@addaleax @MylesBorins
src: remove outdated Neuter() call in node_buffer.cc
cd4a932 
This call was introduced in 827ee49 to avoid a crash in a
later `Neuter()` call that has later been removed in ebbbc5a,
rendering the original call unnecessary.

Refs: #3624
Refs: #5204

PR-URL: #25479
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
deepak1556 pushed a commit to electron/node that referenced this pull request Jul 10, 2019
@addaleax @deepak1556
src: remove outdated Neuter() call in node_buffer.cc
e13e8fe 
This call was introduced in 827ee49 to avoid a crash in a
later `Neuter()` call that has later been removed in ebbbc5a,
rendering the original call unnecessary.

Refs: nodejs/node#3624
Refs: nodejs/node#5204

PR-URL: nodejs/node#25479
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ofrobots @bnoordhuis @indutny @trevnorris