src: fix deprecated SetWeak usage in base-object

PR-URL: nodejs#5204 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
ofrobots · Mar 3, 2016 · bdbd3a2 · bdbd3a2
1 parent ea4f27c
commit bdbd3a2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/base-object-inl.h b/src/base-object-inl.h
@@ -39,7 +39,7 @@ inline Environment* BaseObject::env() const {
 
 template <typename Type>
 inline void BaseObject::WeakCallback(
-    const v8::WeakCallbackData<v8::Object, Type>& data) {
+    const v8::WeakCallbackInfo<Type>& data) {
   Type* self = data.GetParameter();
   self->persistent().Reset();
   delete self;
@@ -53,7 +53,8 @@ inline void BaseObject::MakeWeak(Type* ptr) {
   CHECK_GT(handle->InternalFieldCount(), 0);
   Wrap(handle, ptr);
   handle_.MarkIndependent();
-  handle_.SetWeak<Type>(ptr, WeakCallback<Type>);
+  handle_.SetWeak<Type>(ptr, WeakCallback<Type>,
+                        v8::WeakCallbackType::kParameter);
 }
 
 

diff --git a/src/base-object.h b/src/base-object.h
@@ -40,7 +40,7 @@ class BaseObject {
 
   template <typename Type>
   static inline void WeakCallback(
-      const v8::WeakCallbackData<v8::Object, Type>& data);
+      const v8::WeakCallbackInfo<Type>& data);
 
   v8::Persistent<v8::Object> handle_;
   Environment* env_;