child_process: remove unused internal event #53793

Trott · 2024-07-09T22:27:06Z

Tests pass without this event being emitted. It seems likely orphaned. Remove it.

We should run CITGM on this before landing, just to be super cautious. (Also fine if we want to mark it semver major, just out of caution.)

Tests pass without this event being emitted. Remove it.

avivkeller · 2024-07-09T23:31:52Z

We should run CITGM on this before landing, just to be super cautious.

Added needs-citgm

Trott · 2024-07-10T00:18:55Z

@nodejs/child_process (especially @bnoordhuis who added the code in the first place 9 years ago)

Trott · 2024-07-10T00:19:51Z

It might also be interesting to run a benchmark on this. I don't imagine it will show anything, but stranger things have happened.

avivkeller · 2024-07-10T00:21:57Z

(ignore that - my bad)

nodejs-github-bot · 2024-07-10T15:42:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/60222/

Trott · 2024-07-10T18:07:15Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3453/

Trott · 2024-07-11T15:52:19Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3453/

These CITGM results look OK to me, but it would be good to get a review from someone who is familiar with current/recent failures to make sure there isn't anything new in there. Anyone?

Trott · 2024-07-13T20:07:04Z

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1578/

Trott · 2024-07-18T13:19:50Z

Initial benchmark results

15:11:30                                                                                 confidence improvement accuracy (*)   (**)  (***)
15:11:30 child_process/child-process-exec-stdout.js dur=5 len=1024                                      -0.47 %       ±0.89% ±1.18% ±1.54%
15:11:30 child_process/child-process-exec-stdout.js dur=5 len=256                                       -0.14 %       ±0.59% ±0.78% ±1.02%
15:11:30 child_process/child-process-exec-stdout.js dur=5 len=32768                                     -0.21 %       ±1.11% ±1.47% ±1.92%
15:11:30 child_process/child-process-exec-stdout.js dur=5 len=4096                                       0.07 %       ±0.94% ±1.25% ±1.63%
15:11:30 child_process/child-process-exec-stdout.js dur=5 len=64                                        -0.02 %       ±0.49% ±0.65% ±0.84%
15:11:30 child_process/child-process-params.js params=1 methodName='exec' n=1000                         0.10 %       ±3.63% ±4.83% ±6.28%
15:11:30 child_process/child-process-params.js params=1 methodName='execFile' n=1000                     2.41 %       ±4.99% ±6.64% ±8.65%
15:11:30 child_process/child-process-params.js params=1 methodName='execFileSync' n=1000                -0.60 %       ±4.40% ±5.85% ±7.62%
15:11:30 child_process/child-process-params.js params=1 methodName='execSync' n=1000                    -2.41 %       ±3.90% ±5.19% ±6.77%
15:11:30 child_process/child-process-params.js params=1 methodName='spawn' n=1000                        0.20 %       ±4.60% ±6.12% ±7.97%
15:11:30 child_process/child-process-params.js params=1 methodName='spawnSync' n=1000                    2.55 %       ±4.61% ±6.14% ±8.01%
15:11:30 child_process/child-process-params.js params=2 methodName='exec' n=1000                         0.39 %       ±4.12% ±5.48% ±7.14%
15:11:30 child_process/child-process-params.js params=2 methodName='execFile' n=1000                     0.05 %       ±3.91% ±5.20% ±6.77%
15:11:30 child_process/child-process-params.js params=2 methodName='execFileSync' n=1000                -1.78 %       ±3.71% ±4.93% ±6.42%
15:11:30 child_process/child-process-params.js params=2 methodName='execSync' n=1000              *      4.48 %       ±4.00% ±5.36% ±7.03%
15:11:30 child_process/child-process-params.js params=2 methodName='spawn' n=1000                       -1.14 %       ±3.92% ±5.21% ±6.78%
15:11:30 child_process/child-process-params.js params=2 methodName='spawnSync' n=1000                   -0.20 %       ±4.73% ±6.29% ±8.19%
15:11:30 child_process/child-process-params.js params=3 methodName='exec' n=1000                         0.75 %       ±3.39% ±4.51% ±5.87%
15:11:30 child_process/child-process-params.js params=3 methodName='execFile' n=1000                    -2.12 %       ±3.40% ±4.53% ±5.91%
15:11:30 child_process/child-process-params.js params=3 methodName='execFileSync' n=1000                -1.12 %       ±5.03% ±6.70% ±8.72%
15:11:30 child_process/child-process-params.js params=3 methodName='spawn' n=1000                        2.77 %       ±3.91% ±5.20% ±6.78%
15:11:30 child_process/child-process-params.js params=3 methodName='spawnSync' n=1000                    0.68 %       ±4.72% ±6.28% ±8.17%
15:11:30 child_process/child-process-params.js params=4 methodName='execFile' n=1000                    -1.38 %       ±3.89% ±5.18% ±6.74%
15:11:30 child_process/child-process-read-ipc.js dur=5 len=1024                                          0.06 %       ±1.12% ±1.50% ±1.95%
15:11:30 child_process/child-process-read-ipc.js dur=5 len=1048576                                      -0.20 %       ±2.37% ±3.15% ±4.10%
15:11:30 child_process/child-process-read-ipc.js dur=5 len=16384                                        -0.39 %       ±0.72% ±0.96% ±1.25%
15:11:30 child_process/child-process-read-ipc.js dur=5 len=2097152                                       1.47 %       ±1.63% ±2.17% ±2.82%
15:11:30 child_process/child-process-read-ipc.js dur=5 len=256                                    *     -0.38 %       ±0.33% ±0.44% ±0.58%
15:11:30 child_process/child-process-read-ipc.js dur=5 len=4096                                         -0.02 %       ±0.21% ±0.28% ±0.37%
15:11:30 child_process/child-process-read-ipc.js dur=5 len=64                                           -0.06 %       ±0.44% ±0.59% ±0.77%
15:11:30 child_process/child-process-read-ipc.js dur=5 len=65536                                        -0.19 %       ±0.49% ±0.65% ±0.84%
15:11:30 child_process/child-process-read.js dur=5 len=1024                                             -0.52 %       ±2.25% ±3.00% ±3.90%
15:11:30 child_process/child-process-read.js dur=5 len=256                                               0.36 %       ±1.65% ±2.19% ±2.85%
15:11:30 child_process/child-process-read.js dur=5 len=32768                                            -0.29 %       ±2.78% ±3.70% ±4.81%
15:11:30 child_process/child-process-read.js dur=5 len=4096                                      **     -2.14 %       ±1.36% ±1.81% ±2.36%
15:11:30 child_process/child-process-read.js dur=5 len=64                                                0.62 %       ±2.38% ±3.17% ±4.13%
15:11:30 child_process/spawn-echo.js n=1000                                                              0.84 %       ±1.61% ±2.15% ±2.81%
15:11:30 
15:11:30 Be aware that when doing many comparisons the risk of a false-positive
15:11:30 result increases. In this case, there are 37 comparisons, you can thus
15:11:30 expect the following amount of false-positive results:
15:11:30   1.85 false positives, when considering a   5% risk acceptance (*, **, ***),
15:11:30   0.37 false positives, when considering a   1% risk acceptance (**, ***),
15:11:30   0.04 false positives, when considering a 0.1% risk acceptance (***)

Re-running benchmark CI to confirm that the differences found are random variation and not a result of this change: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1579/

avivkeller · 2024-07-18T13:26:54Z

These CITGM results look OK to me, but it would be good to get a review from someone who is familiar with current/recent failures to make sure there isn't anything new in there. Anyone?

FWIW The CITGM may not be accurate per nodejs/citgm#1067

Trott · 2024-07-18T15:39:02Z

FWIW The CITGM may not be accurate per nodejs/citgm#1067

No, that issue cannot be a factor in the CITGM run that was done for this, since none of the results were green.

Trott · 2024-07-22T16:38:09Z

Initial benchmark results

15:11:30                                                                                 confidence improvement accuracy (*)   (**)  (***)
15:11:30 child_process/child-process-exec-stdout.js dur=5 len=1024                                      -0.47 %       ±0.89% ±1.18% ±1.54%
15:11:30 child_process/child-process-exec-stdout.js dur=5 len=256                                       -0.14 %       ±0.59% ±0.78% ±1.02%
15:11:30 child_process/child-process-exec-stdout.js dur=5 len=32768                                     -0.21 %       ±1.11% ±1.47% ±1.92%
15:11:30 child_process/child-process-exec-stdout.js dur=5 len=4096                                       0.07 %       ±0.94% ±1.25% ±1.63%
15:11:30 child_process/child-process-exec-stdout.js dur=5 len=64                                        -0.02 %       ±0.49% ±0.65% ±0.84%
15:11:30 child_process/child-process-params.js params=1 methodName='exec' n=1000                         0.10 %       ±3.63% ±4.83% ±6.28%
15:11:30 child_process/child-process-params.js params=1 methodName='execFile' n=1000                     2.41 %       ±4.99% ±6.64% ±8.65%
15:11:30 child_process/child-process-params.js params=1 methodName='execFileSync' n=1000                -0.60 %       ±4.40% ±5.85% ±7.62%
15:11:30 child_process/child-process-params.js params=1 methodName='execSync' n=1000                    -2.41 %       ±3.90% ±5.19% ±6.77%
15:11:30 child_process/child-process-params.js params=1 methodName='spawn' n=1000                        0.20 %       ±4.60% ±6.12% ±7.97%
15:11:30 child_process/child-process-params.js params=1 methodName='spawnSync' n=1000                    2.55 %       ±4.61% ±6.14% ±8.01%
15:11:30 child_process/child-process-params.js params=2 methodName='exec' n=1000                         0.39 %       ±4.12% ±5.48% ±7.14%
15:11:30 child_process/child-process-params.js params=2 methodName='execFile' n=1000                     0.05 %       ±3.91% ±5.20% ±6.77%
15:11:30 child_process/child-process-params.js params=2 methodName='execFileSync' n=1000                -1.78 %       ±3.71% ±4.93% ±6.42%
15:11:30 child_process/child-process-params.js params=2 methodName='execSync' n=1000              *      4.48 %       ±4.00% ±5.36% ±7.03%
15:11:30 child_process/child-process-params.js params=2 methodName='spawn' n=1000                       -1.14 %       ±3.92% ±5.21% ±6.78%
15:11:30 child_process/child-process-params.js params=2 methodName='spawnSync' n=1000                   -0.20 %       ±4.73% ±6.29% ±8.19%
15:11:30 child_process/child-process-params.js params=3 methodName='exec' n=1000                         0.75 %       ±3.39% ±4.51% ±5.87%
15:11:30 child_process/child-process-params.js params=3 methodName='execFile' n=1000                    -2.12 %       ±3.40% ±4.53% ±5.91%
15:11:30 child_process/child-process-params.js params=3 methodName='execFileSync' n=1000                -1.12 %       ±5.03% ±6.70% ±8.72%
15:11:30 child_process/child-process-params.js params=3 methodName='spawn' n=1000                        2.77 %       ±3.91% ±5.20% ±6.78%
15:11:30 child_process/child-process-params.js params=3 methodName='spawnSync' n=1000                    0.68 %       ±4.72% ±6.28% ±8.17%
15:11:30 child_process/child-process-params.js params=4 methodName='execFile' n=1000                    -1.38 %       ±3.89% ±5.18% ±6.74%
15:11:30 child_process/child-process-read-ipc.js dur=5 len=1024                                          0.06 %       ±1.12% ±1.50% ±1.95%
15:11:30 child_process/child-process-read-ipc.js dur=5 len=1048576                                      -0.20 %       ±2.37% ±3.15% ±4.10%
15:11:30 child_process/child-process-read-ipc.js dur=5 len=16384                                        -0.39 %       ±0.72% ±0.96% ±1.25%
15:11:30 child_process/child-process-read-ipc.js dur=5 len=2097152                                       1.47 %       ±1.63% ±2.17% ±2.82%
15:11:30 child_process/child-process-read-ipc.js dur=5 len=256                                    *     -0.38 %       ±0.33% ±0.44% ±0.58%
15:11:30 child_process/child-process-read-ipc.js dur=5 len=4096                                         -0.02 %       ±0.21% ±0.28% ±0.37%
15:11:30 child_process/child-process-read-ipc.js dur=5 len=64                                           -0.06 %       ±0.44% ±0.59% ±0.77%
15:11:30 child_process/child-process-read-ipc.js dur=5 len=65536                                        -0.19 %       ±0.49% ±0.65% ±0.84%
15:11:30 child_process/child-process-read.js dur=5 len=1024                                             -0.52 %       ±2.25% ±3.00% ±3.90%
15:11:30 child_process/child-process-read.js dur=5 len=256                                               0.36 %       ±1.65% ±2.19% ±2.85%
15:11:30 child_process/child-process-read.js dur=5 len=32768                                            -0.29 %       ±2.78% ±3.70% ±4.81%
15:11:30 child_process/child-process-read.js dur=5 len=4096                                      **     -2.14 %       ±1.36% ±1.81% ±2.36%
15:11:30 child_process/child-process-read.js dur=5 len=64                                                0.62 %       ±2.38% ±3.17% ±4.13%
15:11:30 child_process/spawn-echo.js n=1000                                                              0.84 %       ±1.61% ±2.15% ±2.81%
15:11:30 
15:11:30 Be aware that when doing many comparisons the risk of a false-positive
15:11:30 result increases. In this case, there are 37 comparisons, you can thus
15:11:30 expect the following amount of false-positive results:
15:11:30   1.85 false positives, when considering a   5% risk acceptance (*, **, ***),
15:11:30   0.37 false positives, when considering a   1% risk acceptance (**, ***),
15:11:30   0.04 false positives, when considering a 0.1% risk acceptance (***)

Re-running benchmark CI to confirm that the differences found are random variation and not a result of this change: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1579/

The re-run shows no significant changes at all in performance. I think this can land.

nodejs-github-bot · 2024-08-01T03:07:12Z

Landed in e2b7e41

Trott · 2024-08-01T03:15:58Z

Out of extreme caution, I'm marking this as semver-major but I'm OK if anyone thinks that goes too far and removes the label. @nodejs/releasers @nodejs/tsc

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495 buffer: * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588 * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613 build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077 * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077 * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081 * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079 * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184 * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427 child_process: * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793 cli: * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761 * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747 * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723 * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611 * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564 crypto: * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019 * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305 * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552 deps: * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536 * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536 * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536 * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077 doc: * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967 * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338 esm: * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848 events: * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889 fs: * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741 * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050 lib: * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965 * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965 * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355 net: * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470 path: * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224 process: * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536 * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077 * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077 * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077 * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174 * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347 stream: * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241 string_decoder: * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957 test: * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077 test_runner: * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881 * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548 * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403 timers: * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678 tls: * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627 tools: * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536 * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077 util: * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744 zlib: * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020 PR-URL: TBD

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495 buffer: * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588 * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613 build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077 * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077 * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081 * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079 * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184 * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427 child_process: * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793 cli: * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761 * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747 * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723 * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611 * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564 crypto: * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019 * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305 * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552 deps: * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536 * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536 * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536 * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077 doc: * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967 * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338 esm: * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848 events: * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889 fs: * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741 * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050 lib: * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965 * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965 * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355 net: * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470 path: * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224 process: * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536 * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077 * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077 * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077 * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174 * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347 stream: * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241 string_decoder: * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957 test: * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077 test_runner: * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881 * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548 * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403 timers: * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678 tls: * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627 tools: * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536 * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077 util: * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744 zlib: * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020 PR-URL: #55338

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) nodejs#53495 buffer: * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) nodejs#54588 * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) nodejs#47613 build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) nodejs#54077 * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) nodejs#54081 * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) nodejs#54079 * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) nodejs#53184 * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) nodejs#45427 child_process: * (SEMVER-MAJOR) remove unused internal event (Rich Trott) nodejs#53793 cli: * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) nodejs#54761 * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) nodejs#52747 * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) nodejs#52723 * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) nodejs#52611 * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) nodejs#52564 crypto: * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) nodejs#55019 * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) nodejs#53305 * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) nodejs#52552 deps: * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) nodejs#54536 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) nodejs#54536 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) nodejs#54077 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) nodejs#54077 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) nodejs#54077 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) nodejs#54077 doc: * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) nodejs#54967 * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) nodejs#54338 esm: * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) nodejs#53848 events: * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) nodejs#54889 fs: * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) nodejs#49741 * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) nodejs#51050 lib: * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) nodejs#54965 * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) nodejs#54965 * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) nodejs#53355 net: * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) nodejs#54470 path: * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) nodejs#54224 process: * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) nodejs#55035 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) nodejs#54077 * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) nodejs#54077 * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) nodejs#54077 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) nodejs#53174 * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) nodejs#52347 stream: * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) nodejs#53241 string_decoder: * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) nodejs#54957 test: * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) nodejs#54077 test_runner: * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) nodejs#54881 * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) nodejs#54548 * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) nodejs#52403 timers: * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) nodejs#46678 tls: * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) nodejs#52627 tools: * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) nodejs#54536 * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) nodejs#54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) nodejs#54077 util: * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) nodejs#52744 zlib: * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) nodejs#55020 PR-URL: nodejs#55338

child_process: remove unused internal event

7dd9b78

Tests pass without this event being emitted. Remove it.

nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels Jul 9, 2024

Trott marked this pull request as draft July 9, 2024 22:27

This comment was marked as resolved.

Sign in to view

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2024

This comment was marked as outdated.

Sign in to view

avivkeller added the needs-citgm PRs that need a CITGM CI run. label Jul 9, 2024

Trott marked this pull request as ready for review July 10, 2024 00:18

avivkeller added needs-benchmark-ci PR that need a benchmark CI run. and removed needs-benchmark-ci PR that need a benchmark CI run. labels Jul 10, 2024

This comment was marked as outdated.

Sign in to view

jasnell approved these changes Jul 10, 2024

View reviewed changes

lpinca approved these changes Jul 10, 2024

View reviewed changes

anonrig approved these changes Jul 11, 2024

View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 27, 2024

trivikr approved these changes Aug 1, 2024

View reviewed changes

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 1, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 1, 2024

nodejs-github-bot merged commit e2b7e41 into nodejs:main Aug 1, 2024
90 checks passed

Trott deleted the remove-it branch August 1, 2024 03:14

Trott added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 1, 2024

RafaelGSS mentioned this pull request Oct 9, 2024

2024-10-16, Version 23.0.0 (Current) #55338

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

child_process: remove unused internal event #53793

child_process: remove unused internal event #53793

Trott commented Jul 9, 2024

This comment was marked as resolved.

This comment was marked as outdated.

avivkeller commented Jul 9, 2024

Trott commented Jul 10, 2024

Trott commented Jul 10, 2024

avivkeller commented Jul 10, 2024

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Jul 10, 2024

Trott commented Jul 10, 2024

Trott commented Jul 11, 2024 •

edited

Loading

Trott commented Jul 13, 2024

Trott commented Jul 18, 2024

avivkeller commented Jul 18, 2024

Trott commented Jul 18, 2024

Trott commented Jul 22, 2024

nodejs-github-bot commented Aug 1, 2024

Trott commented Aug 1, 2024

child_process: remove unused internal event #53793

child_process: remove unused internal event #53793

Conversation

Trott commented Jul 9, 2024

This comment was marked as resolved.

This comment was marked as outdated.

avivkeller commented Jul 9, 2024

Trott commented Jul 10, 2024

Trott commented Jul 10, 2024

avivkeller commented Jul 10, 2024

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Jul 10, 2024

Trott commented Jul 10, 2024

Trott commented Jul 11, 2024 • edited Loading

Trott commented Jul 13, 2024

Trott commented Jul 18, 2024

avivkeller commented Jul 18, 2024

Trott commented Jul 18, 2024

Trott commented Jul 22, 2024

nodejs-github-bot commented Aug 1, 2024

Trott commented Aug 1, 2024

Trott commented Jul 11, 2024 •

edited

Loading