lib: implement interface converter and use it for AbortSignal validation #54965

jazelly · 2024-09-16T11:17:17Z

This PR contains 2 commits.

The first one implements interface converter as per the spec.
The one after uses the implemented interface converter to properly validate AbortSiganls in AbortSignal.any

Fixes: #54962

lib/internal/abort_controller.js

codecov · 2024-09-16T13:06:52Z

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.03%. Comparing base (53ede87) to head (82da5e9).
Report is 185 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/webidl.js	94.11%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54965      +/-   ##
==========================================
- Coverage   88.07%   88.03%   -0.05%     
==========================================
  Files         652      652              
  Lines      183542   183778     +236     
  Branches    35862    35855       -7     
==========================================
+ Hits       161653   161783     +130     
- Misses      15144    15249     +105     
- Partials     6745     6746       +1

Files with missing lines	Coverage Δ
lib/internal/abort_controller.js	`97.90% <100.00%> (-0.01%)`	⬇️
lib/internal/webidl.js	`93.89% <94.11%> (-0.69%)`	⬇️

... and 46 files with indirect coverage changes

lib/internal/webidl.js

atlowChemi · 2024-09-18T08:13:27Z

I am marking this as semver-major PRs that contain breaking changes and should be released in the next major version. since as far as I understand, this would break for any user-land implementation of AbortSignal (https://www.npmjs.com/package/abort-controller etc)

jazelly · 2024-09-18T13:37:05Z

I am marking this as semver-major

I agree this would be a semver-major. Does it mean a CITGM is required?

this would break for any user-land implementation of AbortSignal

Would it be better to remove this change? This is unrelated to the issue that the PR is fixing and it can be avoided.

KhafraDev · 2024-09-18T13:41:09Z

Is there any documentation for supporting third party abortcontrollers? If not I could see this landing as a bug fix.

jazelly · 2024-09-19T01:13:36Z

There is only one benchmark test coverring abort_controller and it's only covering the AbortController.abort, which is, IMO, not affected by this PR.

@anonrig In that case, would it be better if I raise another PR to add benchmark tests to cover AbortSignal.any and aborted, which are the ones affected by this PR, before proceeding this?

test/parallel/test-internal-webidl.js

nodejs-github-bot · 2024-09-19T04:15:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62549/ 💛

RedYetiDev · 2024-09-19T15:19:26Z

@nodejs/tsc per nodejs/Release#1034

benjamingr

Not brand checking AbortSignal was an intentional design choice in order to enable userland to migrate to using Node's AbortSignal.

We can choose to break that compatibility but it would have to be semver-major and require @nodejs/tsc's opinion since it's an ecosystem concern (this is likely to break userland code)

benjamingr · 2024-09-19T17:24:27Z

To be clear - since this breaks userland I want to see how the TSC and namely people who were involved in the original discussion ( @jasnell @mcollina @ronag ) feel about this change.

I'm personally +0 (I'd like it but not at the cost of extensive breakage)

KhafraDev · 2024-09-19T18:06:59Z

We made the same decision in undici to drop third party AbortController/AbortSignal support.

benjamingr · 2024-09-19T18:16:00Z

Thinking about this more userland AbortController libraries have tens of millions of weekly downloads so I'm -0.5 (not for this change but still not blocking)

We made the same decision in undici to drop third party AbortController/AbortSignal support.

When did it happen (assuming it affects Node's fetch)? Was there any breakage?

atlowChemi · 2024-09-19T18:22:24Z

I am -1 for this change.
The top 4 user-land implementations on npm have almost 60 million weekly downloads

KhafraDev · 2024-09-19T21:13:59Z

When did it happen (assuming it affects Node's fetch)? Was there any breakage?

v7, which is releasing soon-ish. Breakage is unimportant here - it was undocumented behavior that broke compatibility with other implementations and the spec. If we implement a spec, we need to accept its burden too. If there are/were performance concerns, those need to be fixed in node core, not handed off to user land to create crappy (not to be offensive) abortcontroller implementations to be used instead.

jazelly · 2024-09-19T23:46:55Z

Would like share some of my humble opinions here.

Standard is more important to pursue compared to the support of 3rd party library - If we take a step back and look at this issue itself, it points out an inconsistency between node and other runtimes. Just because of that, it's a must fix, as the whole point of having a standard (please correct me if I'm wrong) is to allow users to confidently write code to be run any runtime without conditional check. From that sense, the original issue breaks that, and I don't see other ways to do so without brand checking.
Number of downloads is not an accurate factor to consider - This change specifically updates for the validation of AbortSignal.any. (let's not think about the aborted(), as it can be taken out of the PR.) AFAIK, the only way the userland could break is when they use a combination of ThirdPartyAbortController and node's AbortSignal.any.
```
AbortSignal.any([new ThirdPartyAbortController().signal ])
```
That is, even though there are 60,000,000 weekly downloads, it doesn not mean this could extensively break their users (yes, not the library itself, but their users, e.g. some of library doesn't use AbortSignal.any).

So what factor should we look at? Honestly, I don't know. I don't have other factor to look at to justify how breaky it is, but just want to point out not to too focus on the number of downloads for this PR. If the PR is overhauling the validateAbortSignal function, then absolutely, the number of downloads is a good indicator and CITGM will definitely tell us something.

I think the decision to make is whether or not we want to phase in brand check completely, i.e. drop support to 3rd party libs, or leaving it half-half is acceptable?

RedYetiDev · 2024-09-19T23:49:17Z

FWIW the "breakability" of some libraries can be tested with a CITGM

mcollina

lgtm

mcollina · 2024-09-20T08:17:05Z

I'd like it but not at the cost of extensive breakage

The cost of keeping support for 3rd party implementation is maintainers' headaches. Long-term is an untenable proposition.

benjamingr · 2024-09-21T18:42:30Z

v7, which is releasing soon-ish. Breakage is unimportant here - it was undocumented behavior that broke compatibility with other implementations and the spec. If we implement a spec, we need to accept its burden too.

This is true for AbortSignal.any and fetch but none of the other many Node.js APIs that currently take AbortSignals. The breakage can be nontrivial and at the very least this would need a CITGM run given userland implementations of AbortSignal have tens of millions of weekly downloads.

If we remove a feature, we need to assess breakage and minimize it.

jazelly · 2024-09-24T00:34:11Z

If we remove a feature, we need to assess breakage and minimize it.

In addition to CITGM, is there anything else I can do to help assess the breakage? IIUC, the users we concern here are mostly the users using 3rd party AbortSignal library with the code running on Node.

To minimize the influence, would it be helpful if this goes into deprecation cycle, considering this was a feature. (not a suggestion but just having this question : ))

jakecastelli · 2024-09-26T00:27:36Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3477/

benjamingr

CITGM looks good and this only replaces the one place, I pinged Matteo if there is interest we should follow up with a PR that replaces validateAbortSignal with the brand check

PR-URL: #54965 Fixes: #54962 Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot · 2024-09-29T08:45:25Z

Landed in 27dab9d...e973c3e

PR-URL: #54965 Fixes: #54962 Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495 buffer: * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588 * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613 build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077 * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077 * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081 * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079 * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184 * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427 child_process: * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793 cli: * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761 * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747 * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723 * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611 * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564 crypto: * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019 * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305 * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552 deps: * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536 * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536 * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536 * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077 doc: * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967 * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338 esm: * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848 events: * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889 fs: * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741 * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050 lib: * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965 * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965 * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355 net: * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470 path: * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224 process: * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536 * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077 * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077 * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077 * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174 * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347 stream: * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241 string_decoder: * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957 test: * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077 test_runner: * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881 * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548 * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403 timers: * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678 tls: * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627 tools: * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536 * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077 util: * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744 zlib: * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020 PR-URL: TBD

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495 buffer: * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588 * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613 build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077 * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077 * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081 * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079 * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184 * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427 child_process: * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793 cli: * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761 * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747 * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723 * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611 * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564 crypto: * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019 * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305 * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552 deps: * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536 * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536 * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536 * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077 doc: * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967 * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338 esm: * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848 events: * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889 fs: * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741 * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050 lib: * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965 * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965 * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355 net: * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470 path: * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224 process: * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536 * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077 * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077 * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077 * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174 * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347 stream: * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241 string_decoder: * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957 test: * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077 test_runner: * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881 * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548 * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403 timers: * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678 tls: * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627 tools: * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536 * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077 util: * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744 zlib: * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020 PR-URL: #55338

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 16, 2024

jazelly force-pushed the validate-abort-signal branch from dd6e62f to 8f1cafc Compare September 16, 2024 11:30

jazelly marked this pull request as ready for review September 16, 2024 11:56

aduh95 reviewed Sep 16, 2024

View reviewed changes

lib/internal/abort_controller.js Show resolved Hide resolved

RedYetiDev added abortcontroller Issues and PRs related to the AbortController API web-standards Issues and PRs related to Web APIs labels Sep 16, 2024

jazelly commented Sep 16, 2024

View reviewed changes

lib/internal/webidl.js Show resolved Hide resolved

atlowChemi reviewed Sep 16, 2024

View reviewed changes

lib/internal/webidl.js Show resolved Hide resolved

KhafraDev reviewed Sep 16, 2024

View reviewed changes

lib/internal/webidl.js Show resolved Hide resolved

jazelly force-pushed the validate-abort-signal branch from 8f1cafc to ad5664f Compare September 17, 2024 11:49

atlowChemi added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 18, 2024

anonrig added the needs-benchmark-ci PR that need a benchmark CI run. label Sep 18, 2024

KhafraDev reviewed Sep 19, 2024

View reviewed changes

test/parallel/test-internal-webidl.js Outdated Show resolved Hide resolved

jazelly added 2 commits September 19, 2024 12:06

lib: implement interface converter in webidl

ce65d65

lib: validate signals with interface converter

82da5e9

jazelly force-pushed the validate-abort-signal branch from ad5664f to 82da5e9 Compare September 19, 2024 02:37

KhafraDev approved these changes Sep 19, 2024

View reviewed changes

jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024

jakecastelli added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 19, 2024

benjamingr requested changes Sep 19, 2024

View reviewed changes

RedYetiDev removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 19, 2024

mcollina approved these changes Sep 20, 2024

View reviewed changes

jasnell approved these changes Sep 21, 2024

View reviewed changes

jakecastelli added the needs-citgm PRs that need a CITGM CI run. label Sep 22, 2024

benjamingr approved these changes Sep 29, 2024

View reviewed changes

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Sep 29, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2024

nodejs-github-bot closed this Sep 29, 2024

RafaelGSS mentioned this pull request Oct 9, 2024

2024-10-16, Version 23.0.0 (Current) #55338

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib: implement interface converter and use it for AbortSignal validation #54965

lib: implement interface converter and use it for AbortSignal validation #54965

jazelly commented Sep 16, 2024 •

edited

Loading

codecov bot commented Sep 16, 2024 •

edited

Loading

atlowChemi commented Sep 18, 2024

jazelly commented Sep 18, 2024

KhafraDev commented Sep 18, 2024

jazelly commented Sep 19, 2024 •

edited

Loading

nodejs-github-bot commented Sep 19, 2024 •

edited by jakecastelli

Loading

RedYetiDev commented Sep 19, 2024

benjamingr left a comment

benjamingr commented Sep 19, 2024

KhafraDev commented Sep 19, 2024

benjamingr commented Sep 19, 2024

atlowChemi commented Sep 19, 2024

KhafraDev commented Sep 19, 2024

jazelly commented Sep 19, 2024 •

edited

Loading

RedYetiDev commented Sep 19, 2024

mcollina left a comment

mcollina commented Sep 20, 2024

benjamingr commented Sep 21, 2024

jazelly commented Sep 24, 2024 •

edited

Loading

jakecastelli commented Sep 26, 2024

benjamingr left a comment

nodejs-github-bot commented Sep 29, 2024

lib: implement interface converter and use it for AbortSignal validation #54965

lib: implement interface converter and use it for AbortSignal validation #54965

Conversation

jazelly commented Sep 16, 2024 • edited Loading

codecov bot commented Sep 16, 2024 • edited Loading

Codecov Report

atlowChemi commented Sep 18, 2024

jazelly commented Sep 18, 2024

KhafraDev commented Sep 18, 2024

jazelly commented Sep 19, 2024 • edited Loading

nodejs-github-bot commented Sep 19, 2024 • edited by jakecastelli Loading

RedYetiDev commented Sep 19, 2024

benjamingr left a comment

Choose a reason for hiding this comment

benjamingr commented Sep 19, 2024

KhafraDev commented Sep 19, 2024

benjamingr commented Sep 19, 2024

atlowChemi commented Sep 19, 2024

KhafraDev commented Sep 19, 2024

jazelly commented Sep 19, 2024 • edited Loading

RedYetiDev commented Sep 19, 2024

mcollina left a comment

Choose a reason for hiding this comment

mcollina commented Sep 20, 2024

benjamingr commented Sep 21, 2024

jazelly commented Sep 24, 2024 • edited Loading

jakecastelli commented Sep 26, 2024

benjamingr left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Sep 29, 2024

jazelly commented Sep 16, 2024 •

edited

Loading

codecov bot commented Sep 16, 2024 •

edited

Loading

jazelly commented Sep 19, 2024 •

edited

Loading

nodejs-github-bot commented Sep 19, 2024 •

edited by jakecastelli

Loading

jazelly commented Sep 19, 2024 •

edited

Loading

jazelly commented Sep 24, 2024 •

edited

Loading