crypto: add validFromDate and validToDate fields to X509Certificate

[RulerOfCakes]

Resolves #52931.

Since OpenSSL already provides validity checking based on the current time, it may be handy to provide such checks as a part of the X509Certificate API exposed by node. I have made some simple changes to provide such functionality using the default behavior of X509_cmp_timeframe() provided by OpenSSL.

Edit: Instead of providing the user with the date string format provided by OpenSSL's formatting for ASN.1 time objects, I have added parsing logic accordingly to provide them in the form of Javascript Date objects instead to make user interaction easier with these fields.

[nodejs-github-bot]

Review requested:

• @nodejs/crypto

[codecov]

Codecov Report

Attention: Patch coverage is 84.78261% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.06%. Comparing base (c1ec099) to head (68b880e).
Report is 343 commits behind head on main.

Files with missing lines	Patch %	Lines
src/crypto/crypto_x509.cc	80.76%	0 Missing and 5 partials ⚠️
lib/internal/crypto/x509.js	90.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54159      +/-   ##
==========================================
+ Coverage   87.08%   88.06%   +0.98%     
==========================================
  Files         648      652       +4     
  Lines      182217   183592    +1375     
  Branches    34956    35864     +908     
==========================================
+ Hits       158684   161689    +3005     
+ Misses      16819    15141    -1678     
- Partials     6714     6762      +48     

Files with missing lines	Coverage Δ
lib/internal/crypto/x509.js	92.01% <90.00%> (+9.67%)	⬆️
src/crypto/crypto_x509.cc	72.40% <80.76%> (+0.14%)	⬆️

... and 215 files with indirect coverage changes

[mertcanaltin]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62356/

[richardlau]

Looks like there are relevant test failures:

• 32-bit ARM: https://ci.nodejs.org/job/node-test-commit-arm/54787/nodes=ubuntu2204-armv7l/testReport/junit/(root)/parallel/test_crypto_x509/

---
duration_ms: 114.407
exitcode: 1
severity: fail
stack: |-
  node:assert:126
    throw new AssertionError(obj);
    ^

  AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
  + actual - expected

  + 2024-04-04T08:44:05.000Z
  - 2296-06-17T21:40:37.000Z
      at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-arm/test/parallel/test-crypto-x509.js:100:10)
      at Module._compile (node:internal/modules/cjs/loader:1546:14)
      at Module._extensions..js (node:internal/modules/cjs/loader:1691:10)
      at Module.load (node:internal/modules/cjs/loader:1317:32)
      at Module._load (node:internal/modules/cjs/loader:1127:12)
      at TracingChannel.traceSync (node:diagnostics_channel:315:14)
      at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
      at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:166:5)
      at node:internal/main/run_main_module:30:49 {
    generatedMessage: true,
    code: 'ERR_ASSERTION',
    actual: 2024-04-04T08:44:05.000Z,
    expected: 2296-06-17T21:40:37.000Z,
    operator: 'deepStrictEqual'
  }

  Node.js v23.0.0-pre
...

• Windows: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/30234/RUN_SUBSET=0,nodes=win10-COMPILED_BY-vs2022/testReport/junit/(root)/parallel/test_crypto_x509/

---
duration_ms: 1339.007
exitcode: 1
severity: fail
stack: |-
  node:assert:126
    throw new AssertionError(obj);
    ^

  AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
  + actual - expected

  + 2024-04-04T08:44:05.000Z
  - 2296-06-17T21:40:37.000Z
      at Object.<anonymous> (c:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-crypto-x509.js:100:10)
      at Module._compile (node:internal/modules/cjs/loader:1546:14)
      at Module._extensions..js (node:internal/modules/cjs/loader:1691:10)
      at Module.load (node:internal/modules/cjs/loader:1317:32)
      at Module._load (node:internal/modules/cjs/loader:1127:12)
      at TracingChannel.traceSync (node:diagnostics_channel:315:14)
      at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
      at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:166:5)
      at node:internal/main/run_main_module:30:49 {
    generatedMessage: true,
    code: 'ERR_ASSERTION',
    actual: 2024-04-04T08:44:05.000Z,
    expected: 2296-06-17T21:40:37.000Z,
    operator: 'deepStrictEqual'
  }

  Node.js v23.0.0-pre
...

[RulerOfCakes]

Of course, time_t is long and it caused an issue on 32-bit systems + windows x64. 🤦 Hopefully fixing again for one last time.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62505/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62512/

[nodejs-github-bot]

Landed in 29f31c6