src: use better return types in KVStore #54539

targos · 2024-08-24T13:14:22Z

Use v8::Maybe<void> instead of v8::Maybe<bool> and handle error
from AssignFromObject.
An empty v8::Maybe is supposed to be returned when an exception is
pending. Use std::optional instead to indicate a missing value in
Get(key).

- Use `v8::Maybe<void>` instead of `v8::Maybe<bool>` and handle error from `AssignFromObject`. - An empty `v8::Maybe` is supposed to be returned when an exception is pending. Use `std::optional` instead to indicate a missing value in `Get(key)`.

targos · 2024-08-24T13:16:20Z

Note that I didn't change MaybeLocal<String> Get(Isolate* isolate, Local<String> key) and v8::Maybe<bool> AssignToObject because they are less straightforward (when they return an empty Maybe(Local), it could be either because an exception is pending, or for another reason.

targos · 2024-08-24T13:16:26Z

/cc @nodejs/cpp-reviewers

targos · 2024-08-24T14:11:01Z

The mistake was obvious.

codecov · 2024-08-24T15:51:35Z

Codecov Report

Attention: Patch coverage is 84.37500% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.33%. Comparing base (9edf4a0) to head (6fcc1a6).
Report is 337 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_env_var.cc	81.25%	2 Missing and 1 partial ⚠️
src/node_worker.cc	80.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #54539   +/-   ##
=======================================
  Coverage   87.32%   87.33%           
=======================================
  Files         649      649           
  Lines      182603   182607    +4     
  Branches    35042    35042           
=======================================
+ Hits       159464   159471    +7     
+ Misses      16400    16397    -3     
  Partials     6739     6739

Files with missing lines	Coverage Δ
src/inspector_profiler.cc	`77.56% <100.00%> (+0.27%)`	⬆️
src/node_credentials.cc	`69.14% <100.00%> (+0.76%)`	⬆️
src/node_dotenv.cc	`81.70% <100.00%> (ø)`
src/util.h	`89.91% <ø> (ø)`
src/node_worker.cc	`83.44% <80.00%> (-0.60%)`	⬇️
src/node_env_var.cc	`84.81% <81.25%> (+0.31%)`	⬆️

... and 21 files with indirect coverage changes

nodejs-github-bot · 2024-08-24T21:03:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61426/

nodejs-github-bot · 2024-08-26T13:20:53Z

Commit Queue failed

- Loading data for nodejs/node/pull/54539
✔  Done loading data for nodejs/node/pull/54539
----------------------------------- PR info ------------------------------------
Title      src: use better return types in KVStore (#54539)
Author     Michaël Zasso <targos@protonmail.com> (@targos)
Branch     targos:kv-optional -> nodejs:main
Labels     c++, lib / src, needs-ci, commit-queue-squash
Commits    2
 - src: use better return types in KVStore
 - fixup
Committers 1
 - Michaël Zasso <targos@protonmail.com>
PR-URL: https://github.com/nodejs/node/pull/54539
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54539
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 24 Aug 2024 13:14:22 GMT
   ✔  Approvals: 5
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/54539#pullrequestreview-2258733830
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/54539#pullrequestreview-2258750609
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54539#pullrequestreview-2258973417
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/54539#pullrequestreview-2258999489
   ✔  - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/54539#pullrequestreview-2259303546
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2024-08-24T21:03:59Z: https://ci.nodejs.org/job/node-test-pull-request/61426/
- Querying data for job/node-test-pull-request/61426/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/10560540424

- Use `v8::Maybe<void>` instead of `v8::Maybe<bool>` and handle error from `AssignFromObject`. - An empty `v8::Maybe` is supposed to be returned when an exception is pending. Use `std::optional` instead to indicate a missing value in `Get(key)`. PR-URL: #54539 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

targos · 2024-08-26T13:33:48Z

Landed in 8f1fa03

- Use `v8::Maybe<void>` instead of `v8::Maybe<bool>` and handle error from `AssignFromObject`. - An empty `v8::Maybe` is supposed to be returned when an exception is pending. Use `std::optional` instead to indicate a missing value in `Get(key)`. PR-URL: #54539 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

- Use `v8::Maybe<void>` instead of `v8::Maybe<bool>` and handle error from `AssignFromObject`. - An empty `v8::Maybe` is supposed to be returned when an exception is pending. Use `std::optional` instead to indicate a missing value in `Get(key)`. PR-URL: nodejs#54539 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

src: use better return types in KVStore

6d33af3

- Use `v8::Maybe<void>` instead of `v8::Maybe<bool>` and handle error from `AssignFromObject`. - An empty `v8::Maybe` is supposed to be returned when an exception is pending. Use `std::optional` instead to indicate a missing value in `Get(key)`.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 24, 2024

tniessen approved these changes Aug 24, 2024

View reviewed changes

targos marked this pull request as draft August 24, 2024 13:55

This comment was marked as resolved.

Sign in to view

fixup

6fcc1a6

targos marked this pull request as ready for review August 24, 2024 14:10

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 24, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 24, 2024

This comment was marked as outdated.

Sign in to view

addaleax approved these changes Aug 24, 2024

View reviewed changes

jasnell approved these changes Aug 24, 2024

View reviewed changes

RafaelGSS approved these changes Aug 24, 2024

View reviewed changes

targos added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 25, 2024

VoltrexKeyva approved these changes Aug 25, 2024

View reviewed changes

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 26, 2024

targos closed this Aug 26, 2024

targos deleted the kv-optional branch August 26, 2024 13:33

RafaelGSS mentioned this pull request Aug 30, 2024

v22.8.0 proposal #54560

Merged

targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src: use better return types in KVStore #54539

src: use better return types in KVStore #54539

targos commented Aug 24, 2024

targos commented Aug 24, 2024

targos commented Aug 24, 2024

This comment was marked as resolved.

targos commented Aug 24, 2024

This comment was marked as outdated.

codecov bot commented Aug 24, 2024 •

edited

Loading

nodejs-github-bot commented Aug 24, 2024

nodejs-github-bot commented Aug 26, 2024

targos commented Aug 26, 2024

src: use better return types in KVStore #54539

src: use better return types in KVStore #54539

Conversation

targos commented Aug 24, 2024

targos commented Aug 24, 2024

targos commented Aug 24, 2024

This comment was marked as resolved.

targos commented Aug 24, 2024

This comment was marked as outdated.

codecov bot commented Aug 24, 2024 • edited Loading

Codecov Report

nodejs-github-bot commented Aug 24, 2024

nodejs-github-bot commented Aug 26, 2024

targos commented Aug 26, 2024

codecov bot commented Aug 24, 2024 •

edited

Loading