Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use better return types in KVStore #54539

Closed
wants to merge 2 commits into from
Closed

src: use better return types in KVStore #54539

wants to merge 2 commits into from

Commits on Aug 24, 2024

  1. src: use better return types in KVStore 

    - Use `v8::Maybe<void>` instead of `v8::Maybe<bool>` and handle error
  from `AssignFromObject`.
- An empty `v8::Maybe` is supposed to be returned when an exception is
  pending. Use `std::optional` instead to indicate a missing value in
  `Get(key)`.
    @targos
    targos committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    6d33af3 View commit details
    Browse the repository at this point in the history

  2. fixup

    @targos
    targos committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    6fcc1a6 View commit details
    Browse the repository at this point in the history