Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: notify via slack when review-wanted #55102

Merged
merged 3 commits into from
Sep 27, 2024
Merged

build: notify via slack when review-wanted #55102

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc44c62
build: notify via slack when review-wanted
RafaelGSS Sep 24, 2024
2334e32
fixup! build: notify via slack when review-wanted
RafaelGSS Sep 24, 2024
e776845
fixup! fixup! build: notify via slack when review-wanted
RafaelGSS Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions .github/workflows/notify-on-review-wanted.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
name: Notify on Review Wanted
on:
issues:
types: [labeled]
Comment on lines +3 to +4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't make sense to trigger that on issues.

Suggested change
issues:
types: [labeled]

Although, shouldn't we instead add a job to .github/workflows/comment-labeled.yml instead of creating a new workflow?

pull_request_target:
types: [labeled]

permissions:
contents: read
RafaelGSS marked this conversation as resolved.
Show resolved Hide resolved

jobs:
notifyOnReviewWanted:
name: Notify on Review Wanted
if: github.repository == 'nodejs/node' && github.event.label == 'review wanted'
runs-on: ubuntu-latest
steps:
- name: Determine PR or Issue
id: define-message
run: |
if [[ -n "${{ github.event.pull_request.number }}" ]]; then
number="${{ github.event.pull_request.number }}"
link="https://github.com/${{ github.repository }}/pull/$number"
echo "message=The PR (#$number) requires review from Node.js maintainers. See: $link" >> "$GITHUB_OUTPUT"
echo "title=${{ github.actor }} asks for attention on pull request #$number" >> "$GITHUB_OUTPUT"
else
number="${{ github.event.issue.number }}"
link="https://github.com/${{ github.repository }}/issues/$number"
echo "message=The issue (#$number) requires review from Node.js maintainers. See: $link" >> "$GITHUB_OUTPUT"
echo "title=${{ github.actor }} asks for attention on issue #$number" >> "$GITHUB_OUTPUT"
fi

- name: Slack Notification
uses: rtCamp/action-slack-notify@4e5fb42d249be6a45a298f3c9543b111b02f7907 # 2.3.0
env:
SLACK_COLOR: '#DE512A'
SLACK_ICON: https://github.com/nodejs.png?size=48
SLACK_TITLE: ${{ steps.define-message.outputs.title }}
SLACK_MESSAGE: ${{ steps.define-message.outputs.message }}
SLACK_USERNAME: nodejs-bot
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}