test: move localizationd data from test-icu-env to external file
#55618
+372
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
i18n-api
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55618 +/- ##
==========================================
- Coverage 88.43% 88.43% -0.01%
==========================================
Files 654 654
Lines 187662 187720 +58
Branches 36117 36143 +26
==========================================
+ Hits 165962 166012 +50
- Misses 14938 14944 +6
- Partials 6762 6764 +2 |
|
I like the idea. I think there should be separate versions of the fixture per ICU version and then we could remove the current restriction that the test only runs with the bundled/builtin ICU. |
github-actions
bot
removed
the
request-ci
richardlau
added
the
commit-queue-squash
richardlau
approved these changes
Nov 1, 2024
aduh95
reviewed
Nov 2, 2024
| "mr": "५,८६,९२०.६१७ तासांपूर्वी", | ||
| "te": "5,86,920.617 గంటల క్రితం" | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we add an EOL at the EOF?
There was a problem hiding this comment.
Sure. Should this become a lint rule? Right now some json fixtures have EOL at the end, some do not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #50515 (comment)
Related to: #55551 (the data in current PR is generated using version
75.1)