Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add known issue test for #7788 #7793

Merged
merged 1 commit into from
Jul 20, 2016
Merged

test: add known issue test for #7788 #7793

merged 1 commit into from
Jul 20, 2016

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 19, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

15157c3 changed the CLI REPL to default to useGlobal: false by default. This caused the regression seen in #7788. This commit adds a known issue test while a proper resolution is determined.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 19, 2016
@cjihrig cjihrig mentioned this pull request Jul 19, 2016
Closed
@addaleax addaleax added the repl Issues and PRs related to the REPL subsystem. label Jul 19, 2016
@cjihrig cjihrig mentioned this pull request Jul 19, 2016
Merged
2 tasks
@Trott
Copy link
Member

Trott commented Jul 19, 2016

LGTM if CI likes it

@cjihrig
Copy link
Contributor Author

cjihrig commented Jul 20, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/3354/

@cjihrig
Copy link
Contributor Author

cjihrig commented Jul 20, 2016

The only failure was unrelated.

@cjihrig
test: add known issue test for nodejs#7788
8c0f776 
15157c3 changed the CLI REPL
to default to useGlobal: false by default. This caused the
regression seen in nodejs#7788.
This commit adds a known issue test while a proper resolution
is determined.

Refs: nodejs#5703
Refs: nodejs#7788
PR-URL: nodejs#7793
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig cjihrig merged commit 8c0f776 into nodejs:master Jul 20, 2016
@cjihrig cjihrig deleted the test branch July 20, 2016 17:05
evanlucas pushed a commit that referenced this pull request Jul 21, 2016
@cjihrig @evanlucas
test: add known issue test for #7788
2e05e65 
15157c3 changed the CLI REPL
to default to useGlobal: false by default. This caused the
regression seen in #7788.
This commit adds a known issue test while a proper resolution
is determined.

Refs: #5703
Refs: #7788
PR-URL: #7793
Reviewed-By: Rich Trott <rtrott@gmail.com>
@evanlucas evanlucas mentioned this pull request Jul 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @Trott @MylesBorins @addaleax @nodejs-github-bot