test: fix flaky fs-watch tests #8115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santigimeno
added
macos
|
LGTM |
|
/cc @bnoordhuis |
|
LGTM |
`test-fs-watch-recursive` and `test-fs-watch` were both watching the same folder: `tmp/testsubdir` so running them sequentially on `OS X` could make `test-fs-watch` to fail due to events generated in the other test. Make them watch a random directory to fix the issue. Fixes: nodejs#8045
|
Updated so the random directory is not created twice in |
| @@ -78,7 +73,9 @@ setImmediate(function() { | |||
| fs.writeFileSync(filepathTwoAbs, 'pardner'); | |||
| }); | |||
|
|
|||
| fs.mkdirSync(testsubdir, 0o700); | |||
| var filenameThree = 'newfile.txt'; | |||
There was a problem hiding this comment.
Sure, I was just trying to keep the modifications to a minimum. Should I use const everywhere on the test or just in the variables I moved?
There was a problem hiding this comment.
I'd just update the variables you're moving. It won't change the size of the diff.
|
LGTM |
|
Done. Thanks! |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Aug 18, 2016
`test-fs-watch-recursive` and `test-fs-watch` were both watching the same folder: `tmp/testsubdir` so running them sequentially on `OS X` could make `test-fs-watch` to fail due to events generated in the other test. Make them watch a random directory to fix the issue. Fixes: #8045 PR-URL: #8115 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 5f617c5. Thank you @santigimeno ! |
evanlucas
pushed a commit
that referenced
this pull request
Aug 24, 2016
`test-fs-watch-recursive` and `test-fs-watch` were both watching the same folder: `tmp/testsubdir` so running them sequentially on `OS X` could make `test-fs-watch` to fail due to events generated in the other test. Make them watch a random directory to fix the issue. Fixes: #8045 PR-URL: #8115 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
test-fs-watch-recursiveandtest-fs-watchwere both watching thesame folder:
tmp/testsubdirso running them sequentially onOS Xcould make
test-fs-watchto fail due to events generated in the othertest. Make them watch a random directory to fix the issue.
Fixes: #8045