Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky fs-watch tests #8115

Closed
wants to merge 3 commits into from
Closed

test: fix flaky fs-watch tests #8115

wants to merge 3 commits into from

Commits on Aug 16, 2016

  1. test: fix flaky fs-watch tests 

    `test-fs-watch-recursive` and `test-fs-watch` were both watching the
same folder: `tmp/testsubdir` so running them sequentially on `OS X`
could make `test-fs-watch` to fail due to events generated in the other
test. Make them watch a random directory to fix the issue.

Fixes: nodejs#8045
    @santigimeno
    santigimeno committed Aug 16, 2016
    Configuration menu
    Copy the full SHA
    357e6c7 View commit details
    Browse the repository at this point in the history

  2. fixup: don't create the random directory twice

    @santigimeno
    santigimeno committed Aug 16, 2016
    Configuration menu
    Copy the full SHA
    57ebac0 View commit details
    Browse the repository at this point in the history

  3. constify

    @santigimeno
    santigimeno committed Aug 16, 2016
    Configuration menu
    Copy the full SHA
    9ce9c02 View commit details
    Browse the repository at this point in the history