doc: add added: information for util
#8206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
util
| @@ -125,6 +134,9 @@ util.format(1, 2, 3); // '1 2 3' | |||
| ``` | |||
|
|
|||
| ## util.inherits(constructor, superConstructor) | |||
| <!-- YAML | |||
| added: v0.3.0 | |||
There was a problem hiding this comment.
This is when the module has been renamed. It was called sys before, not sure if it's better to show when the method was added to sys.
There was a problem hiding this comment.
This is probably fine.
There was a problem hiding this comment.
I think of the added marks as a reference for the user to understand "how far back can I expect this thing to be in this place", so existence elsewhere before then is kind of irrelevant.
|
LGTM |
3 similar comments
|
LGTM |
|
LGTM |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Aug 23, 2016
PR-URL: #8206 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
|
Landed in 16f4b8e |
evanlucas
pushed a commit
that referenced
this pull request
Aug 24, 2016
PR-URL: #8206 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
2 tasks
36 tasks
|
This doesn't land cleanly on v4.x please feel free to manually backport |
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Oct 1, 2016
PR-URL: nodejs#8206 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Ref: #6578