doc: add added: information for crypto
#8281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
crypto
lpinca
force-pushed
the
add/added-crypto
branch
from
402116b to
d2320b9
Compare
| @@ -972,6 +1130,9 @@ The `key` is the raw key used by the `algorithm` and `iv` is an | |||
| [buffers][`Buffer`]. | |||
|
|
|||
| ### crypto.createDiffieHellman(prime[, prime_encoding][, generator][, generator_encoding]) | |||
There was a problem hiding this comment.
This signature was added in v0.11.12. Maybe it makes sense to use this version instead of v0.5.0. See below for the original signature.
Edit: To be picky the second argument of the original version was the encoding so I'm not sure.
There was a problem hiding this comment.
I think 0.11.12 does make more sense. If someone wants to look at the 0.10 docs to find the original that's fine.
|
LGTM + left comment |
lpinca
force-pushed
the
add/added-crypto
branch
from
d2320b9 to
0515f3d
Compare
|
Rubber-stamp LGTM |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Sep 12, 2016
PR-URL: #8281 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in cfe8278 |
36 tasks
Fishrock123
pushed a commit
that referenced
this pull request
Sep 14, 2016
PR-URL: #8281 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
|
This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport |
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Oct 1, 2016
PR-URL: nodejs#8281 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Feb 8, 2018
2 tasks
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18651 Refs: nodejs#8281 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Ref: #6578