Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix footer sizing #860

Closed
wants to merge 1 commit into from
Closed

Conversation

Fishrock123
Copy link
Contributor

reduced to the minimal amount, any less shows a white bar.

fixes nodejs/iojs.org#189

R=@chrisdickinson

reduced to the minimal amount, any less shows a white bar.
@Fishrock123
Copy link
Contributor Author

Even if temporary, this is better than a giant grey box.

@Fishrock123 Fishrock123 added the doc Issues and PRs related to the documentations. label Feb 16, 2015
@chrisdickinson
Copy link
Contributor

so long as this works on pages that are <innerHeight, LGTM. alternatively, you could populate that space with io.js links :)

@brendanashworth
Copy link
Contributor

Looks good to me. @Fishrock123 would you like to delimit the io.js links to a later pull request and have me merge this one?

Fishrock123 added a commit that referenced this pull request Feb 23, 2015
reduced to the minimal amount, any less shows a white bar.

Semver: patch
PR-URL: #860
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
@chrisdickinson
Copy link
Contributor

Merged in cb22bc9. Thanks!

This was referenced Feb 23, 2015
@Fishrock123 Fishrock123 deleted the doc-fix-footer branch March 26, 2015 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants