deps: enable node-gyp iojs.lib download checksum #918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally disabled in commit 5de334c ("deps: make node-gyp work again
on windows") due to the then-website lacking the requisite SHASUMS.txt
or SHASUMS256.txt files. The website has a SHASUMS256.txt now so start
checksumming the download again.
|
we've had SHASUMS256.txt from the beginning though, not quite sure why this was commented out in the first place but 👍 from me |
| @@ -295,8 +295,7 @@ function install (gyp, argv, callback) { | |||
| // check content shasums | |||
| for (var k in contentShasums) { | |||
| log.verbose('validating download checksum for ' + k, '(%s == %s)', contentShasums[k], expectShasums[k]) | |||
| // TODO(piscisaureus) re-enable checksum verification when the correct files are in place. | |||
| if (false || contentShasums[k] !== expectShasums[k]) { | |||
There was a problem hiding this comment.
false ||
So it wasn't even disabled in the first place?
There was a problem hiding this comment.
Apparently not. It makes sense that everything was fine, given Rod's comment.
bnoordhuis
added a commit
that referenced
this pull request
Feb 23, 2015
Originally disabled in commit 5de334c ("deps: make node-gyp work again
on windows") due to the then-website lacking the requisite SHASUMS.txt
or SHASUMS256.txt files. The website has a SHASUMS256.txt now so start
checksumming the download again.
PR-URL: #918
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Thanks! Landed in da730c7 |
This was referenced Feb 23, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally disabled in commit 5de334c ("deps: make node-gyp work again
on windows") due to the then-website lacking the requisite SHASUMS.txt
or SHASUMS256.txt files. The website has a SHASUMS256.txt now so start
checksumming the download again.
R=@piscisaureus, /cc @othiym23