Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard to read the navigation menu items in light mode #6398

Closed
rluvaton opened this issue Mar 2, 2024 · 7 comments · Fixed by #6413
Closed

Hard to read the navigation menu items in light mode #6398

rluvaton opened this issue Mar 2, 2024 · 7 comments · Fixed by #6413
Labels
bug good first issue Issues for newcomers help wanted website redesign Issue/PR part of the Node.js Website Redesign

Comments

@rluvaton
Copy link
Member

rluvaton commented Mar 2, 2024

URL:

https://beta-node-js-org.vercel.app/en

Browser Name:

Safari

Browser Version:

Good question

Operating System:

iOS 17

How to reproduce the issue:

  1. Go to website
  2. Click on the menu bar
  3. Change to light mode

IMG_9525

@rluvaton rluvaton added the bug label Mar 2, 2024
@AugustinMauroy
Copy link
Contributor

FYI: the strange hexagon redering is Safari bug.
I thinks the effect should be "push" by the deployment of the nav

@ovflowd
Copy link
Member

ovflowd commented Mar 2, 2024

FYI: the strange hexagon redering is Safari bug. I thinks the effect should be "push" by the deployment of the nav

We should give a solid background to the nav. Can you make a PR?, the background shouldn't be transparent.

@ovflowd
Copy link
Member

ovflowd commented Mar 2, 2024

Now regarding the hexagons being like this, I wasn't able to reproduce this on my Safari on latest iOS (iPhone 15 Pro).

Is this some accessibility setting?

@AugustinMauroy
Copy link
Contributor

AugustinMauroy commented Mar 2, 2024

Is this some accessibility setting?

I never active some accessibility setting so IDK ?

I have this randomly on my Mac with safari 17.1

@ovflowd
Copy link
Member

ovflowd commented Mar 2, 2024

I have this randomly on my Mac with safari 17.1

Weird, I never seen this happening, but I'll keep an eye on that. Meanwhile, we should give a solid background for the expanded nav.

@ovflowd ovflowd added help wanted good first issue Issues for newcomers website redesign Issue/PR part of the Node.js Website Redesign labels Mar 3, 2024
@ovflowd
Copy link
Member

ovflowd commented Mar 3, 2024

@AugustinMauroy want to tackle it?

@AugustinMauroy
Copy link
Contributor

Yeah I'm working on

@AugustinMauroy AugustinMauroy mentioned this issue Mar 3, 2024
5 tasks
@AugustinMauroy AugustinMauroy linked a pull request Mar 3, 2024 that will close this issue
5 tasks
ovflowd pushed a commit that referenced this issue Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Issues for newcomers help wanted website redesign Issue/PR part of the Node.js Website Redesign
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants