Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #6398 #6413

Merged
merged 2 commits into from
Mar 3, 2024
Merged

Fix: #6398 #6413

merged 2 commits into from
Mar 3, 2024

Conversation

AugustinMauroy
Copy link
Contributor

Description

Add background to NavBar and footer. To hide "effect".

Validation

Related Issues

Close #6398

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@AugustinMauroy AugustinMauroy added design website redesign Issue/PR part of the Node.js Website Redesign github_actions:pull-request Trigger Pull Request Checks labels Mar 3, 2024
@AugustinMauroy AugustinMauroy requested a review from a team as a code owner March 3, 2024 11:00
@AugustinMauroy AugustinMauroy linked an issue Mar 3, 2024 that may be closed by this pull request
Copy link

vercel bot commented Mar 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 3, 2024 11:00am

@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 3, 2024
Copy link

github-actions bot commented Mar 3, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 96 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 95 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 92 🟢 100 🟢 92 🔗

Copy link

github-actions bot commented Mar 3, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
80.18% (433/540) 79.65% (137/172) 73.07% (76/104)

Unit Test Report

Tests Skipped Failures Errors Time
88 0 💤 0 ❌ 0 🔥 4.446s ⏱️

@ovflowd ovflowd enabled auto-merge March 3, 2024 11:58
@ovflowd ovflowd disabled auto-merge March 3, 2024 11:58
@ovflowd ovflowd merged commit 2f6f355 into main Mar 3, 2024
27 checks passed
@ovflowd ovflowd deleted the fix-6398 branch March 3, 2024 11:58
@ovflowd
Copy link
Member

ovflowd commented Mar 3, 2024

I've fast tracker this visual issue.

@ovflowd ovflowd added the fast-track Fast Tracking PRs label Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design fast-track Fast Tracking PRs website redesign Issue/PR part of the Node.js Website Redesign
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hard to read the navigation menu items in light mode
2 participants