Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add missing localization for Community part #1737

Merged
1 commit merged into from Jul 15, 2018
Merged

[Fix] Add missing localization for Community part #1737

1 commit merged into from Jul 15, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jul 15, 2018

For https://nodejs.org/zh-cn/about/, we've missed a translation for the left title of Community.

And this also happens with almost every other languages EXCEPT English. We DO NOT have community in our site.json.

Before:
before

After:
about

/cc:
@nodejs/nodejs-tw
@nodejs/nodejs-ja
@nodejs/nodejs-uk
@nodejs/nodejs-ko
@nodejs/nodejs-de
@nodejs/nodejs-it
@nodejs/nodejs-fr
@nodejs/nodejs-es

@ghost ghost requested a review from yorkie July 15, 2018 11:14
For `https://nodejs.org/zh-cn/about/`, we've missed a translation for
the left title of `Community`. And this also happens with almost every
other languages EXCEPT English. We DO NOT have `community` in our
`site.json`.
@ghost ghost removed the request for review from yorkie July 15, 2018 11:23
@ghost ghost merged commit 110f136 into nodejs:master Jul 15, 2018
@vsemozhetbyt
Copy link
Contributor

locale/uk/ PR: #1738

@ghost
Copy link
Author

ghost commented Jul 15, 2018

@vsemozhetbyt :Just try another submit onto here, it should be OK with you.
Or if you can, you can try to use commit and rebase to merge the two submits into one, which looks better.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant