Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Add missing localizations to locale/uk/ #1738

Merged
1 commit merged into from
Jul 21, 2018
Merged

[Fix] Add missing localizations to locale/uk/ #1738

1 commit merged into from
Jul 21, 2018

Conversation

vsemozhetbyt
Copy link
Contributor

Refs: #1737

@vsemozhetbyt vsemozhetbyt mentioned this pull request Jul 15, 2018
Merged
@ghost
Copy link

ghost commented Jul 15, 2018

Suggestions：
After modification, please run：

1）npm run build
2）npm run test
3）npm run start

Then go to http://localhost:8080/uk and you'll see what you want by clicking pages.

@ghost ghost requested a review from fhemberger July 15, 2018 11:42
@vsemozhetbyt
Copy link
Contributor Author

I've added more missing localizations.

@vsemozhetbyt vsemozhetbyt changed the title [Fix] Add localization for Community to locale/uk/ [Fix] Add missing localizations to locale/uk/ Jul 15, 2018
@vsemozhetbyt
Copy link
Contributor Author

http://localhost:8080/uk seems OK.

@ghost
Copy link

ghost commented Jul 21, 2018

There seems to be ONLY ONE left for you to translate in this file:
/locale/uk/download/index.md
default

@vsemozhetbyt
Copy link
Contributor Author

I've added some more translations in the /locale/uk/download/index.md.

@ghost ghost merged commit 76a361d into nodejs:master Jul 21, 2018
@ghost
Copy link

ghost commented Jul 21, 2018

Thanks anyway!

@vsemozhetbyt vsemozhetbyt deleted the loc-uk-community branch July 21, 2018 08:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhemberger fhemberger Awaiting requested review from fhemberger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vsemozhetbyt