-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nextjs and mdx compiler #6071
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
js syntax highlighting is not working
✅ https://nodejs.org/en/learn/manipulating-files/working-with-folders-in-nodejs
❌ https://nodejs-org-git-feat-next-14-lightweight-mdx-compiler-openjs.vercel.app/en/learn/manipulating-files/working-with-file-descriptors-in-nodejs
at times these pages don't render. cannot reliably recreate yet. LH seemed to have the same issue
❌ https://nodejs-org-git-feat-next-14-lightweight-mdx-compiler-openjs.vercel.app/en/about
@bmuenzenmeyer feel free to re-review this ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I compared the preview with nodejs.org. Also, fixes the markdown formatted tables
Description
This PR does a significant rework on our MDX Parsing and updates Next.js to v14 and MDX to v3.
Motivation
We used a 3rd party package to parse
mdx
with source strings, aka,next-mdx-remote
"maintained" by Hashicorp. But as it became more apparent that we don't need a 3rd party solution and we can use a lightweight solution, I've decided to use the core of MDX itself@mdxjs/mdx
without any extra sugar etc.@mdxjs
and all theunified
ecosystem (vfile, unified, remark, rehype, etc)remark-gfm
plugin instead of handpicking a few versions and specific plugins and trying to make a live with itThe implementation is bare-bones and very simple, and it works fantastically.
Validation
Pages should be rendered as usual without content change...