Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render openssf badge by parsing as mdx #6093

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Conversation

bmuenzenmeyer
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer commented Nov 3, 2023

Description

#6071 removed rehype-raw which we were relying on to render the raw <img/> tag inside our security-reporting.md file. This change restores the rendered image by using MDX.

Validation

The badge is visible again.

image

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner November 3, 2023 03:03
Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 3, 2023 3:03am

Copy link

github-actions bot commented Nov 3, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 95%
95.41% (333/349) 77.21% (61/79) 93.05% (67/72)

Unit Test Report

Tests Skipped Failures Errors Time
42 0 💤 0 ❌ 0 🔥 4.812s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Nov 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 3, 2023
@mikeesto mikeesto added this pull request to the merge queue Nov 5, 2023
Merged via the queue into main with commit bf9dd75 Nov 5, 2023
14 checks passed
@mikeesto mikeesto deleted the fix-openssf-badge-render branch November 5, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants