-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove FileReader #2728
remove FileReader #2728
Conversation
When we eventually drop support for node 18, we can finally get rid of our File implementation, which means we won't have to run any FileAPI WPTs anymore! |
Unfortunately I don't think we can drop Node v18 anytime soon because it’ll be lts for another year. |
Of course not 😅. I was just talking about way in the future. We still have our own File. |
Rebase to next branch? |
28d81d2
to
fefe90d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2728 +/- ##
=======================================
Coverage ? 88.44%
=======================================
Files ? 81
Lines ? 7384
Branches ? 0
=======================================
Hits ? 6531
Misses ? 853
Partials ? 0 ☔ View full report in Codecov by Sentry. |
can we land this? 👀 |
I made a PR to remove FileReader from fetch tests. This is safe to land in the meantime. web-platform-tests/wpt#44893 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fetch: improve output for FormData * fetch: improve output for Response * fetch: improve output for Request * fetch: improve output for Request * feat: repair code * feat: repair code * feat: repair code * fix: repair codes & tests * fix: repair tests & response & request class * Update response.js Co-authored-by: Khafra <maitken033380023@gmail.com> * fix: test repair --------- Co-authored-by: Mert Can Altin <mert.altin@trendyol.com> Co-authored-by: Khafra <maitken033380023@gmail.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
* test: improve performance of issue-803 test * increase timeout
* for some reason this fixes the test * cleanup custom format * fixup
* chore(.github/workflows): factor out test running * chore: add nightly tests Closes nodejs#2932
…2974) Bumps node from `4999fa1` to `577f8eb`. --- updated-dependencies: - dependency-name: node dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: add types for composed dispatchers * Update types/dispatcher.d.ts * refactor: adjust --------- Co-authored-by: Matteo Collina <hello@matteocollina.com>
* fix: count for error response and network errors * test: add specific test for fix * fix: conflict * refactor: address feedback
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
) * fix(fetch): properly redirect non-ascii location header url * chore: fix typo * test: use simpler code * chore: clarify what the code does * chore: add comment * chore: normalize location url only if it contains invalid character * chore: apply suggestion See: nodejs#2971 (comment) * chore: remove redundant condition check
* Remove double-stringify in setCookie * Remove unnecessary semicolon
* make eventsource properties enumberable * Use kEnumerableProperty for eventsource immutable fields * Apply suggestions from code review * Apply suggestions from code review --------- Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com>
* perf: optimization of request creation * refactor: reduce variable * rename to normalizedMethodRecords * fixup * suggested change * fixup * bench: add benchmark * Update request.js * Update lib/web/fetch/request.js * Apply suggestions from code review * Apply suggestions from code review * Update lib/web/fetch/request.js * Update request.js * Update lib/web/fetch/request.js --------- Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com>
* Refactored passing object to function params * Refactor write function argument order * Updated argument order in writeBuffer function
Bumps [borp](https://github.com/mcollina/borp) from 0.14.0 to 0.15.0. - [Release notes](https://github.com/mcollina/borp/releases) - [Commits](https://github.com/mcollina/borp/commits/v0.15.0) --- updated-dependencies: - dependency-name: borp dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [c8](https://github.com/bcoe/c8) from 9.1.0 to 10.0.0. - [Release notes](https://github.com/bcoe/c8/releases) - [Changelog](https://github.com/bcoe/c8/blob/main/CHANGELOG.md) - [Commits](bcoe/c8@v9.1.0...v10.0.0) --- updated-dependencies: - dependency-name: c8 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add missing error classes to types * test new types * test error includes data with count when etag mismatch * test content-range mismatch error * remove test debugging
* export interceptor to type def file Fixes: nodejs#3308 * fixup! add a test * fixup! add retry, redirect, dump and remove createRedirectInterceptor --------- Co-authored-by: jake li <jake.li@sine.co>
…3326) Bumps node from `e6d4495` to `075a5cc`. --- updated-dependencies: - dependency-name: node dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ezekiel Keator <ekeator@paypal.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: github-actions <github-actions@github.com>
* fix nodejs#3337 * fixup
* fix: types interceptors default export * test for bugs in typescript
Co-authored-by: github-actions <github-actions@github.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
…3355) Bumps node from `075a5cc` to `9af472b`. --- updated-dependencies: - dependency-name: node dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* websocket: don't use pooled buffer in mask pool * add test * fixup * fixup
3723521
to
dd98299
Compare
No description provided.