fix: closed client should be able to reconnect #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added test |
|
I've put a few commits into this PR to avoid the whole endless conflicts thing. The commits should be somewhat related. Hope you don't mind. |
ronag
force-pushed
the
closed-reconnect
branch
4 times, most recently
from
116fb46 to
5bd60c2
Compare
mcollina
requested changes
May 3, 2020
| @@ -265,7 +265,7 @@ test('invalid URL throws', (t) => { | |||
| }) | |||
|
|
|||
| test('POST which fails should error response', (t) => { | |||
| t.plan(2) | |||
| t.plan(4) | |||
There was a problem hiding this comment.
It didn’t call all the calllbacks before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.