-
Notifications
You must be signed in to change notification settings - Fork 107
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bug: fix stuck halfOpen when using errorFilter (#389)
* Fix stuck halfOpen when using errorFilter When an error is filtered by an errorFilter the request is considered neither success nor failure, leaving the circuit in an inconsistent state. This fixes that issue by emitting success event when the error is filtered. * Call fallback when an error is filtered When an error is filtered, it is considered a success, however we need a result to resolve with, this way, we should call fallback to get a valid result. If there is no fallback, we reject to give the application a chance to handle the error.
- Loading branch information
Showing
4 changed files
with
56 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters