Fix stuck halfOpen when using errorFilter #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance
requested changes
Nov 26, 2019
lance
reviewed
Nov 26, 2019
When an error is filtered by an errorFilter the request is considered neither success nor failure, leaving the circuit in an inconsistent state. This fixes that issue by emitting success event when the error is filtered.
lance
requested changes
Dec 2, 2019
When an error is filtered, it is considered a success, so the fallback function should not be used. In that case the circuit would return the error as returned by the underlying service.
|
@jairelton thanks for making the change. In reviewing it, I realized that past behavior has been that, whether or not the error is filtered, What I have suggested you do is changing the the behavior, and now I am having second thoughts about it because this would really be a |
|
@lholmquist do you mind taking a look and letting me know what you think? |
lholmquist
reviewed
Dec 12, 2019
When an error is filtered, it is considered a success, however we need a result to resolve with, this way, we should call fallback to get a valid result. If there is no fallback, we reject to give the application a chance to handle the error.
|
@lholmquist I'm going to land this for now, but let's keep an eye on how filters/fallbacks are used going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #388