chore(ssa refactor): Handle codegen for literals #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
reviewed
Apr 24, 2023
kevaundray
reviewed
Apr 24, 2023
kevaundray
reviewed
Apr 24, 2023
kevaundray
reviewed
Apr 24, 2023
kevaundray
reviewed
Apr 24, 2023
crates/noirc_evaluator/src/ssa_refactor/ssa_builder/function_builder.rs
Outdated
Show resolved
Hide resolved
kevaundray
reviewed
Apr 24, 2023
crates/noirc_evaluator/src/ssa_refactor/ssa_builder/function_builder.rs
Outdated
Show resolved
Hide resolved
kevaundray
reviewed
Apr 24, 2023
kevaundray
previously approved these changes
Apr 24, 2023
Implement debug printing for the new ssa ir
kevaundray
approved these changes
Apr 24, 2023
TomAFrench
added a commit
that referenced
this pull request
Apr 29, 2023
* master: (223 commits) chore(noir): Release 0.5.0 (#1202) chore(ci): Utilize new workflow to build binaries (#1250) chore(ssa refactor): Fix loading from mutable parameters (#1248) fix(wasm): add std after dependencies (#1245) chore(ssa refactor): Fix no returns & duplicate main (#1243) chore(ssa refactor): Implement intrinsics (#1241) chore(ssa refactor): Implement first-class functions (#1238) chore: address clippy warnings (#1239) chore(ssa refactor): Implement function calls (#1235) chore(ssa refactor): Implement mutable and immutable variables (#1234) chore(ssa refactor): Fix recursive printing of blocks (#1230) feat(noir): added assert keyword (#1227) chore(ssa refactor): Implement ssa-gen for indexing, cast, constrain, if, unary (#1225) feat(noir): added `distinct` keyword (#1219) chore(nargo): update panic message to suggest searching for similar issues (#1224) chore(ssa refactor): Update how instruction result types are retrieved (#1222) chore(ssa refactor): Implement ssa-gen for binary, block, tuple, extract-tuple-field, and semi expressions (#1217) chore: add RUST_BACKTRACE environment variable to nix config (#1216) chore(ssa): Add intial control flow graph (#1200) chore(ssa refactor): Handle codegen for literals (#1209) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Order
This PR depends on the function parameters PR (for easier merging), and is set to merge into it as well. This ensures that the diffs for this PR are more clear.
Description
Summary of changes
Since this is also the first change that actually inserts instructions into the ssa form, some functions have been added to help handle that as well.
Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context