Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ssa refactor): Add debug printing for the new ssa ir #1211

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Apr 24, 2023

Related issue(s)

Resolves #

Description

Implements Display for Function to print out a representation of all of the function's instructions for debugging purposes.

Summary of changes

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@kevaundray kevaundray self-requested a review April 24, 2023 19:50
@kevaundray kevaundray merged commit 12691f7 into jf/ssa-literals Apr 24, 2023
@kevaundray kevaundray deleted the jf/ssa-printing branch April 24, 2023 21:09
@kevaundray
Copy link
Contributor

Oh accidentally merged into the other branch -- sorry, lets just merge the other branch in as I've aproved both of them

@jfecher
Copy link
Contributor Author

jfecher commented Apr 24, 2023

Merging in this order just means I have one less merge conflict to fix anyway

jfecher added a commit that referenced this pull request Apr 24, 2023
* Add Context structs and start ssa gen pass

* Fix block arguments

* Fix clippy lint

* Use the correct dfg

* Rename contexts to highlight the inner contexts are shared rather than used directly

* Correctly handle function parameters

* Rename Nested to Tree; add comment

* Add codegen for literals

* PR feedback

* chore(ssa refactor): Add debug printing for the new ssa ir (#1211)

Implement debug printing for the new ssa ir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants