fix: Minimal change to avoid reverting entire PR #6685 #6778

jfecher · 2024-12-11T20:29:10Z

Description

Problem*

Resolves #6763
Replaces #6774

Summary*

Always incrementing the rc of an array from a let binding fixes the issue in the test in #6763. We can revert this one part of #6685 for now and hopefully re-add it later when we figure out why it breaks.

Additional Context

This means reference counts essentially start at 2 again so the first mutation of an array will always incur a copy.

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions · 2024-12-11T20:32:11Z

Changes to Brillig bytecode sizes

Generated at commit: 49947ad0441f5b107f89144e2a58d5bfdcae4e43, compared to commit: f6957faf50025afc053a32d86398d0823253066b

🧾 Summary (10% most significant diffs)

Program	Brillig opcodes (+/-)	%
wildcard_type	+27 ❌	+8.23%
brillig_nested_arrays	+27 ❌	+7.11%
regression_struct_array_conditional	+27 ❌	+4.46%
brillig_constant_reference_regression	+3 ❌	+3.45%
brillig_rc_regression_6123	+6 ❌	+3.35%
array_to_slice	+21 ❌	+2.86%
fold_call_witness_condition	+3 ❌	+2.68%
conditional_2	+3 ❌	+2.59%
regression_4202	+3 ❌	+2.46%

Full diff report 👇

Program	Brillig opcodes (+/-)	%
wildcard_type	355 (+27)	+8.23%
brillig_nested_arrays	407 (+27)	+7.11%
regression_struct_array_conditional	633 (+27)	+4.46%
brillig_constant_reference_regression	90 (+3)	+3.45%
brillig_rc_regression_6123	185 (+6)	+3.35%
array_to_slice	754 (+21)	+2.86%
fold_call_witness_condition	115 (+3)	+2.68%
conditional_2	119 (+3)	+2.59%
regression_4202	125 (+3)	+2.46%
conditional_regression_661	130 (+3)	+2.36%
regression_4449	781 (+18)	+2.36%
array_dedup_regression	262 (+6)	+2.34%
regression_6674_1	262 (+6)	+2.34%
regression_6674_2	268 (+6)	+2.29%
nested_array_dynamic_simple	137 (+3)	+2.24%
side_effects_constrain_array	138 (+3)	+2.22%
loop_invariant_regression	140 (+3)	+2.19%
keccak256	2,245 (+48)	+2.18%
brillig_cow_assign	141 (+3)	+2.17%
brillig_pedersen	586 (+12)	+2.09%
pedersen_check	586 (+12)	+2.09%
conditional_regression_short_circuit	1,327 (+27)	+2.08%
fold_2_to_17	593 (+12)	+2.07%
6	1,251 (+24)	+1.96%
sha256	2,528 (+48)	+1.94%
sha256_var_size_regression	1,904 (+36)	+1.93%
fold_complex_outputs	640 (+12)	+1.91%
bench_2_to_17	331 (+6)	+1.85%
sha256_var_witness_const_regression	1,362 (+24)	+1.79%
slices	2,414 (+42)	+1.77%
sha256_var_padding_regression	5,300 (+90)	+1.73%
higher_order_functions	707 (+12)	+1.73%
nested_dyn_array_regression_5782	178 (+3)	+1.71%
nested_array_in_slice	1,445 (+24)	+1.69%
uhashmap	14,415 (+237)	+1.67%
simple_shield	929 (+15)	+1.64%
brillig_oracle	376 (+6)	+1.62%
pedersen_hash	376 (+6)	+1.62%
aes128_encrypt	564 (+9)	+1.62%
no_predicates_numeric_generic_poseidon	769 (+12)	+1.59%
fold_numeric_generic_poseidon	769 (+12)	+1.59%
7_function	591 (+9)	+1.55%
ram_blowup_regression	999 (+15)	+1.52%
merkle_insert	820 (+12)	+1.49%
array_dynamic_blackbox_input	1,059 (+15)	+1.44%
pedersen_commitment	212 (+3)	+1.44%
databus_two_calldata	214 (+3)	+1.42%
to_be_bytes	215 (+3)	+1.42%
sha2_byte	2,824 (+39)	+1.40%
bigint	2,297 (+30)	+1.32%
ecdsa_secp256k1	938 (+12)	+1.30%
array_dynamic_nested_blackbox_input	940 (+12)	+1.29%
conditional_1	1,221 (+15)	+1.24%
brillig_cow_regression	2,233 (+27)	+1.22%
sha256_regression	7,097 (+84)	+1.20%
hashmap	22,151 (+252)	+1.15%
reference_counts	536 (+6)	+1.13%
slice_loop	281 (+3)	+1.08%
regression_6674_3	609 (+6)	+1.00%
array_dynamic	322 (+3)	+0.94%
poseidon2	335 (+3)	+0.90%
hint_black_box	345 (+3)	+0.88%
sha256_brillig_performance_regression	1,737 (+15)	+0.87%
modulus	1,780 (+12)	+0.68%
regression_5252	4,756 (+30)	+0.63%
regression	960 (+6)	+0.63%
poseidonsponge_x5_254	4,377 (+24)	+0.55%
poseidon_bn254_hash	5,535 (+30)	+0.54%
poseidon_bn254_hash_width_3	5,535 (+30)	+0.54%
debug_logs	5,184 (+24)	+0.47%
nested_array_dynamic	2,787 (+9)	+0.32%
strings	944 (+3)	+0.32%
slice_dynamic_index	2,525 (+3)	+0.12%
u128	2,820 (+3)	+0.11%

github-actions · 2024-12-11T20:33:44Z

Peak Memory Sample

Program	Peak Memory
keccak256	78.64M
workspace	121.97M
regression_4709	294.72M
ram_blowup_regression	2.44G
private-kernel-tail	208.79M
private-kernel-reset	862.88M
private-kernel-inner	307.69M
parity-root	174.43M

github-actions · 2024-12-11T20:35:16Z

Compilation Sample

Program	Compilation Time	%
sha256_regression	0m1.507s	6%
regression_4709	0m1.519s	0%
ram_blowup_regression	0m16.985s	2%
private-kernel-tail	0m1.192s	-5%
private-kernel-reset	0m8.767s	2%
private-kernel-inner	0m2.838s	20%
parity-root	0m0.991s	-5%
noir-contracts	2m50.055s	2%

github-actions · 2024-12-11T20:46:05Z

Changes to number of Brillig opcodes executed

Generated at commit: 49947ad0441f5b107f89144e2a58d5bfdcae4e43, compared to commit: f6957faf50025afc053a32d86398d0823253066b

🧾 Summary (10% most significant diffs)

Program	Brillig opcodes (+/-)	%
pedersen_hash	+143 ❌	+27.03%
merkle_insert	+858 ❌	+26.85%
simple_shield	+584 ❌	+24.33%
brillig_pedersen	+193 ❌	+24.13%
pedersen_check	+193 ❌	+24.13%
pedersen_commitment	+47 ❌	+18.88%
wildcard_type	+71 ❌	+13.60%
brillig_oracle	+318 ❌	+13.04%
regression_struct_array_conditional	+185 ❌	+11.97%

Full diff report 👇

Program	Brillig opcodes (+/-)	%
pedersen_hash	672 (+143)	+27.03%
merkle_insert	4,053 (+858)	+26.85%
simple_shield	2,984 (+584)	+24.33%
brillig_pedersen	993 (+193)	+24.13%
pedersen_check	993 (+193)	+24.13%
pedersen_commitment	296 (+47)	+18.88%
wildcard_type	593 (+71)	+13.60%
brillig_oracle	2,757 (+318)	+13.04%
regression_struct_array_conditional	1,730 (+185)	+11.97%
databus_two_calldata	446 (+47)	+11.78%
sha256_var_padding_regression	227,159 (+22,308)	+10.89%
to_be_bytes	2,455 (+236)	+10.64%
brillig_cow_regression	529,462 (+50,025)	+10.43%
ram_blowup_regression	794,603 (+74,380)	+10.33%
sha256_var_witness_const_regression	7,466 (+632)	+9.25%
conditional_1	5,920 (+495)	+9.12%
aes128_encrypt	4,731 (+393)	+9.06%
7_function	2,549 (+204)	+8.70%
regression_4449	239,145 (+17,853)	+8.07%
array_dynamic_blackbox_input	19,350 (+1,438)	+8.03%
sha256	15,668 (+1,136)	+7.82%
brillig_nested_arrays	380 (+27)	+7.65%
keccak256	34,897 (+2,312)	+7.10%
6	7,850 (+504)	+6.86%
conditional_regression_short_circuit	7,928 (+504)	+6.79%
array_dynamic_nested_blackbox_input	4,759 (+252)	+5.59%
fold_call_witness_condition	70 (+3)	+4.48%
sha256_var_size_regression	17,334 (+720)	+4.33%
sha256_regression	122,104 (+4,924)	+4.20%
fold_numeric_generic_poseidon	5,212 (+205)	+4.09%
no_predicates_numeric_generic_poseidon	5,212 (+205)	+4.09%
sha256_brillig_performance_regression	23,650 (+904)	+3.97%
higher_order_functions	1,285 (+49)	+3.96%
ecdsa_secp256k1	6,989 (+252)	+3.74%
brillig_constant_reference_regression	87 (+3)	+3.57%
regression_6674_3	1,669 (+57)	+3.54%
side_effects_constrain_array	95 (+3)	+3.26%
sha2_byte	46,974 (+1,438)	+3.16%
conditional_2	122 (+3)	+2.52%
conditional_regression_661	123 (+3)	+2.50%
nested_array_dynamic_simple	123 (+3)	+2.50%
brillig_rc_regression_6123	305 (+6)	+2.01%
nested_dyn_array_regression_5782	177 (+3)	+1.72%
array_dedup_regression	1,108 (+18)	+1.65%
nested_array_dynamic	3,773 (+53)	+1.42%
regression_4202	214 (+3)	+1.42%
nested_array_in_slice	1,765 (+24)	+1.38%
fold_complex_outputs	924 (+12)	+1.32%
reference_counts	463 (+6)	+1.31%
array_to_slice	1,706 (+21)	+1.25%
slices	3,536 (+42)	+1.20%
regression_6674_1	834 (+6)	+0.72%
regression_6674_2	840 (+6)	+0.72%
uhashmap	148,004 (+1,056)	+0.72%
hashmap	55,882 (+342)	+0.62%
array_dynamic	501 (+3)	+0.60%
brillig_cow_assign	536 (+3)	+0.56%
u128	25,025 (+131)	+0.53%
regression_5252	924,380 (+4,366)	+0.47%
poseidonsponge_x5_254	185,010 (+864)	+0.47%
debug_logs	5,196 (+24)	+0.46%
poseidon2	698 (+3)	+0.43%
poseidon_bn254_hash	167,238 (+698)	+0.42%
poseidon_bn254_hash_width_3	167,238 (+698)	+0.42%
hint_black_box	726 (+3)	+0.41%
slice_loop	960 (+3)	+0.31%
loop_invariant_regression	1,167 (+3)	+0.26%
regression	2,831 (+6)	+0.21%
strings	1,797 (+3)	+0.17%
slice_dynamic_index	4,685 (+3)	+0.06%
modulus	19,190 (+12)	+0.06%
fold_2_to_17	1,093,934 (+12)	+0.00%
bench_2_to_17	589,844 (+6)	+0.00%

TomAFrench · 2024-12-11T22:15:37Z

I'll check that this fixes the test failures in bloblib and big_curve and then merge this tomorrow.

…oir-lang/noir#6778)

…iant code motion (noir-lang/noir#6782) feat: add `(x | 1)` optimization for booleans (noir-lang/noir#6795) feat: `nargo test -q` (or `nargo test --format terse`) (noir-lang/noir#6776) fix: disable failure persistance in nargo test fuzzing (noir-lang/noir#6777) feat(cli): Verify `return` against ABI and `Prover.toml` (noir-lang/noir#6765) chore(ssa): Activate loop invariant code motion on ACIR functions (noir-lang/noir#6785) fix: use extension in docs link so it also works on GitHub (noir-lang/noir#6787) fix: optimizer to keep track of changing opcode locations (noir-lang/noir#6781) fix: Minimal change to avoid reverting entire PR #6685 (noir-lang/noir#6778)

…tion (noir-lang/noir#6782) feat: add `(x | 1)` optimization for booleans (noir-lang/noir#6795) feat: `nargo test -q` (or `nargo test --format terse`) (noir-lang/noir#6776) fix: disable failure persistance in nargo test fuzzing (noir-lang/noir#6777) feat(cli): Verify `return` against ABI and `Prover.toml` (noir-lang/noir#6765) chore(ssa): Activate loop invariant code motion on ACIR functions (noir-lang/noir#6785) fix: use extension in docs link so it also works on GitHub (noir-lang/noir#6787) fix: optimizer to keep track of changing opcode locations (noir-lang/noir#6781) fix: Minimal change to avoid reverting entire PR #6685 (noir-lang/noir#6778)

Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix: Minimal change to avoid reverting entire PR #6685 (noir-lang/noir#6778) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>

* master: (313 commits) chore: Do not print entire functions when running debug trace (#6814) chore(ci): Active rollup circuits in compilation report (#6813) feat(ssa): Bring back tracking of RC instructions during DIE (#6783) feat: add `nargo test --format json` (#6796) chore: Change Id to use a u32 (#6807) feat(ssa): Hoist MakeArray instructions during loop invariant code motion (#6782) feat: add `(x | 1)` optimization for booleans (#6795) feat: `nargo test -q` (or `nargo test --format terse`) (#6776) fix: disable failure persistance in nargo test fuzzing (#6777) feat(cli): Verify `return` against ABI and `Prover.toml` (#6765) chore(ssa): Activate loop invariant code motion on ACIR functions (#6785) fix: use extension in docs link so it also works on GitHub (#6787) fix: optimizer to keep track of changing opcode locations (#6781) fix: Minimal change to avoid reverting entire PR #6685 (#6778) feat: several `nargo test` improvements (#6728) chore: Try replace callstack with a linked list (#6747) chore: Use `NumericType` not `Type` for casts and numeric constants (#6769) chore(ci): Extend compiler memory report to external repos (#6768) chore(ci): Handle external libraries in compilation timing report (#6750) feat(ssa): Implement missing brillig constraints SSA check (#6658) ...

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.67.1</summary> ## [0.67.1](aztec-package-v0.67.0...aztec-package-v0.67.1) (2024-12-17) ### Miscellaneous * Granular CLI imports to reduce start time ([#10778](#10778)) ([e2fd046](e2fd046)) * Split up protocol contract artifacts ([#10765](#10765)) ([5a9ca18](5a9ca18)) * Trace and handle errors in running promises ([#10645](#10645)) ([4cc0a6d](4cc0a6d)) </details> <details><summary>barretenberg.js: 0.67.1</summary> ## [0.67.1](barretenberg.js-v0.67.0...barretenberg.js-v0.67.1) (2024-12-17) ### Features * PXE browser proving ([#10704](#10704)) ([46da3cc](46da3cc)) ### Bug Fixes * **bb.js:** Use globalThis instead of self ([#10747](#10747)) ([309b5f7](309b5f7)), closes [#10741](#10741) * Casting vk to rawbuffer before wasm so it reads from the correct offset ([#10769](#10769)) ([6a5bcfd](6a5bcfd)) </details> <details><summary>aztec-packages: 0.67.1</summary> ## [0.67.1](aztec-packages-v0.67.0...aztec-packages-v0.67.1) (2024-12-17) ### Features * `nargo test -q` (or `nargo test --format terse`) (noir-lang/noir#6776) ([8956e28](8956e28)) * Add `(x | 1)` optimization for booleans (noir-lang/noir#6795) ([8956e28](8956e28)) * Add `nargo test --format json` (noir-lang/noir#6796) ([d74d0fc](d74d0fc)) * Add tree equality assertions ([#10756](#10756)) ([923826a](923826a)) * **avm:** Migrate simulator memory to a map ([#10715](#10715)) ([64d5f2b](64d5f2b)), closes [#10370](#10370) * Better initialization for permutation mapping components ([#10750](#10750)) ([1516d7f](1516d7f)) * Blobs 2. ([#10188](#10188)) ([d0a4b2f](d0a4b2f)) * **blobs:** Add consensus client url to config ([#10059](#10059)) ([1e15bf5](1e15bf5)) * Check max fees per gas ([#10283](#10283)) ([4e59b06](4e59b06)) * **cli:** Verify `return` against ABI and `Prover.toml` (noir-lang/noir#6765) ([8956e28](8956e28)) * Json output for get_node_info ([#10771](#10771)) ([b086c52](b086c52)) * Leaf index requests to the native world state can now be performed as a batch query ([#10649](#10649)) ([a437e73](a437e73)) * New 17 in 20 IVC bench added to actions ([#10777](#10777)) ([9fbcff6](9fbcff6)) * Note hash management in the AVM ([#10666](#10666)) ([e077980](e077980)) * **p2p:** Activate gossipsub tx validators ([#10695](#10695)) ([9cce2c6](9cce2c6)) * PXE browser proving ([#10704](#10704)) ([46da3cc](46da3cc)) * **ssa:** Bring back tracking of RC instructions during DIE (noir-lang/noir#6783) ([308c5ce](308c5ce)) * **ssa:** Hoist MakeArray instructions during loop invariant code motion (noir-lang/noir#6782) ([8956e28](8956e28)) * Sumcheck with disabled rows ([#10068](#10068)) ([abd2226](abd2226)) * TXE detects duplicate nullifiers ([#10764](#10764)) ([7f70110](7f70110)) ### Bug Fixes * Always remove nullified notes ([#10722](#10722)) ([5e4b46d](5e4b46d)) * Avm gas and non-member ([#10709](#10709)) ([dd8cc7b](dd8cc7b)) * **bb.js:** Use globalThis instead of self ([#10747](#10747)) ([309b5f7](309b5f7)), closes [#10741](#10741) * Cache ([#10692](#10692)) ([1b1306c](1b1306c)) * Casting vk to rawbuffer before wasm so it reads from the correct offset ([#10769](#10769)) ([6a5bcfd](6a5bcfd)) * **ci:** Network-test timing ([#10725](#10725)) ([9c9a2dc](9c9a2dc)) * Disable failure persistance in nargo test fuzzing (noir-lang/noir#6777) ([8956e28](8956e28)) * Get e2e jobs ([#10689](#10689)) ([37e1999](37e1999)) * Give build:fast a try in build ([#10702](#10702)) ([32095f6](32095f6)) * Minimal change to avoid reverting entire PR [#6685](#6685) (noir-lang/noir#6778) ([8956e28](8956e28)) * Optimizer to keep track of changing opcode locations (noir-lang/noir#6781) ([8956e28](8956e28)) * Race condition in block stream ([#10779](#10779)) ([64bccd0](64bccd0)) * Race condition when cleaning epoch proof quotes ([#10795](#10795)) ([f540fbe](f540fbe)) * **testdata:** Relative path calculation ([#10791](#10791)) ([5a530db](5a530db)) * Use correct size for databus_id ([#10673](#10673)) ([95eb658](95eb658)) * Use extension in docs link so it also works on GitHub (noir-lang/noir#6787) ([8956e28](8956e28)) * Use throw instead of reject in broker facade ([#10735](#10735)) ([cc6a72b](cc6a72b)) ### Miscellaneous * `getLogsByTags` request batching in `syncTaggedLogs` ([#10716](#10716)) ([bbbf38b](bbbf38b)) * Add `Instruction::map_values_mut` (noir-lang/noir#6756) ([308c5ce](308c5ce)) * Add errors to abis ([#10697](#10697)) ([5c8e017](5c8e017)) * Add retries for prover node p2p test ([#10699](#10699)) ([4115bf9](4115bf9)) * Add spans to proving job ([#10794](#10794)) ([df3c51b](df3c51b)) * **avm:** Disable fake avm recursive verifier from the public base rollup ([#10690](#10690)) ([b6c9c41](b6c9c41)) * Better reqresp logging + handle empty responses in snappy ([#10657](#10657)) ([934107f](934107f)) * Bump metrics and node pool ([#10745](#10745)) ([9bb88bf](9bb88bf)) * Change Id to use a u32 (noir-lang/noir#6807) ([d74d0fc](d74d0fc)) * **ci:** Active rollup circuits in compilation report (noir-lang/noir#6813) ([308c5ce](308c5ce)) * **ci:** Add bloblib to external checks (noir-lang/noir#6818) ([381b0b8](381b0b8)) * Cleanup after e2e tests ([#10748](#10748)) ([284b0a4](284b0a4)) * Disable ARM CI ([#10682](#10682)) ([b16945b](b16945b)) * Do not print entire functions when running debug trace (noir-lang/noir#6814) ([308c5ce](308c5ce)) * **docs:** Workaround (noir-lang/noir#6819) ([381b0b8](381b0b8)) * Granular CLI imports to reduce start time ([#10778](#10778)) ([e2fd046](e2fd046)) * Hot fixes ([4e00dc4](4e00dc4)) * Log error in retry module ([#10719](#10719)) ([84ea539](84ea539)) * Manage call stacks using a tree (noir-lang/noir#6791) ([381b0b8](381b0b8)) * Move decider PK allocation to methods ([#10670](#10670)) ([1ab9e30](1ab9e30)) * **p2p:** Move services into folders ([#10694](#10694)) ([e28d12a](e28d12a)) * **prover:** Prover node should not gossip attestations ([#10672](#10672)) ([41fc0f0](41fc0f0)) * Remove default export for noir contracts js ([#10762](#10762)) ([c8e7763](c8e7763)) * Remove sinon in favor of a date provider ([#10705](#10705)) ([3d3fabb](3d3fabb)) * Remove spurious echo ([#10774](#10774)) ([5538f8c](5538f8c)) * Replace relative paths to noir-protocol-circuits ([f85fa3f](f85fa3f)) * Replace relative paths to noir-protocol-circuits ([b19c561](b19c561)) * Set max txs in spam test ([#10717](#10717)) ([a50ff6c](a50ff6c)) * Slack notifications for networks ([#10784](#10784)) ([bab9f85](bab9f85)) * Split up protocol contract artifacts ([#10765](#10765)) ([5a9ca18](5a9ca18)) * **ssa:** Activate loop invariant code motion on ACIR functions (noir-lang/noir#6785) ([8956e28](8956e28)) * Sync grafana dashboard ([#10792](#10792)) ([421fb65](421fb65)) * Tagging cleanup ([#10675](#10675)) ([52b541a](52b541a)) * Trace and handle errors in running promises ([#10645](#10645)) ([4cc0a6d](4cc0a6d)) * Update external joiner script for new networks ([#10810](#10810)) ([5f11cf4](5f11cf4)) </details> <details><summary>barretenberg: 0.67.1</summary> ## [0.67.1](barretenberg-v0.67.0...barretenberg-v0.67.1) (2024-12-17) ### Features * Add tree equality assertions ([#10756](#10756)) ([923826a](923826a)) * Better initialization for permutation mapping components ([#10750](#10750)) ([1516d7f](1516d7f)) * Leaf index requests to the native world state can now be performed as a batch query ([#10649](#10649)) ([a437e73](a437e73)) * New 17 in 20 IVC bench added to actions ([#10777](#10777)) ([9fbcff6](9fbcff6)) * Note hash management in the AVM ([#10666](#10666)) ([e077980](e077980)) * Sumcheck with disabled rows ([#10068](#10068)) ([abd2226](abd2226)) ### Bug Fixes * Avm gas and non-member ([#10709](#10709)) ([dd8cc7b](dd8cc7b)) * Use correct size for databus_id ([#10673](#10673)) ([95eb658](95eb658)) ### Miscellaneous * Move decider PK allocation to methods ([#10670](#10670)) ([1ab9e30](1ab9e30)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.67.1</summary> ## [0.67.1](aztec-package-v0.67.0...aztec-package-v0.67.1) (2024-12-17) ### Miscellaneous * Granular CLI imports to reduce start time ([#10778](#10778)) ([e2fd046](e2fd046)) * Split up protocol contract artifacts ([#10765](#10765)) ([5a9ca18](5a9ca18)) * Trace and handle errors in running promises ([#10645](#10645)) ([4cc0a6d](4cc0a6d)) </details> <details><summary>barretenberg.js: 0.67.1</summary> ## [0.67.1](barretenberg.js-v0.67.0...barretenberg.js-v0.67.1) (2024-12-17) ### Features * PXE browser proving ([#10704](#10704)) ([46da3cc](46da3cc)) ### Bug Fixes * **bb.js:** Use globalThis instead of self ([#10747](#10747)) ([309b5f7](309b5f7)), closes [#10741](#10741) * Casting vk to rawbuffer before wasm so it reads from the correct offset ([#10769](#10769)) ([6a5bcfd](6a5bcfd)) </details> <details><summary>aztec-packages: 0.67.1</summary> ## [0.67.1](aztec-packages-v0.67.0...aztec-packages-v0.67.1) (2024-12-17) ### Features * `nargo test -q` (or `nargo test --format terse`) (noir-lang/noir#6776) ([8956e28](8956e28)) * Add `(x | 1)` optimization for booleans (noir-lang/noir#6795) ([8956e28](8956e28)) * Add `nargo test --format json` (noir-lang/noir#6796) ([d74d0fc](d74d0fc)) * Add tree equality assertions ([#10756](#10756)) ([923826a](923826a)) * **avm:** Migrate simulator memory to a map ([#10715](#10715)) ([64d5f2b](64d5f2b)), closes [#10370](#10370) * Better initialization for permutation mapping components ([#10750](#10750)) ([1516d7f](1516d7f)) * Blobs 2. ([#10188](#10188)) ([d0a4b2f](d0a4b2f)) * **blobs:** Add consensus client url to config ([#10059](#10059)) ([1e15bf5](1e15bf5)) * Check max fees per gas ([#10283](#10283)) ([4e59b06](4e59b06)) * **cli:** Verify `return` against ABI and `Prover.toml` (noir-lang/noir#6765) ([8956e28](8956e28)) * Don't store every block number in block indices DB ([#10658](#10658)) ([a3fba84](a3fba84)) * Json output for get_node_info ([#10771](#10771)) ([b086c52](b086c52)) * Leaf index requests to the native world state can now be performed as a batch query ([#10649](#10649)) ([a437e73](a437e73)) * New 17 in 20 IVC bench added to actions ([#10777](#10777)) ([9fbcff6](9fbcff6)) * Note hash management in the AVM ([#10666](#10666)) ([e077980](e077980)) * **p2p:** Activate gossipsub tx validators ([#10695](#10695)) ([9cce2c6](9cce2c6)) * **p2p:** Attestation pool persistence ([#10667](#10667)) ([dacef9f](dacef9f)) * PXE browser proving ([#10704](#10704)) ([46da3cc](46da3cc)) * **ssa:** Bring back tracking of RC instructions during DIE (noir-lang/noir#6783) ([308c5ce](308c5ce)) * **ssa:** Hoist MakeArray instructions during loop invariant code motion (noir-lang/noir#6782) ([8956e28](8956e28)) * Sumcheck with disabled rows ([#10068](#10068)) ([abd2226](abd2226)) * TXE detects duplicate nullifiers ([#10764](#10764)) ([7f70110](7f70110)) ### Bug Fixes * Always remove nullified notes ([#10722](#10722)) ([5e4b46d](5e4b46d)) * Avm gas and non-member ([#10709](#10709)) ([dd8cc7b](dd8cc7b)) * AVM witgen track gas for nested calls and external halts ([#10731](#10731)) ([b8bdb52](b8bdb52)) * **bb.js:** Use globalThis instead of self ([#10747](#10747)) ([309b5f7](309b5f7)), closes [#10741](#10741) * Block building test timeout ([#10812](#10812)) ([2cad3e5](2cad3e5)) * Cache ([#10692](#10692)) ([1b1306c](1b1306c)) * Casting vk to rawbuffer before wasm so it reads from the correct offset ([#10769](#10769)) ([6a5bcfd](6a5bcfd)) * **ci:** Network-test timing ([#10725](#10725)) ([9c9a2dc](9c9a2dc)) * Disable failure persistance in nargo test fuzzing (noir-lang/noir#6777) ([8956e28](8956e28)) * Get e2e jobs ([#10689](#10689)) ([37e1999](37e1999)) * Give build:fast a try in build ([#10702](#10702)) ([32095f6](32095f6)) * Minimal change to avoid reverting entire PR [#6685](#6685) (noir-lang/noir#6778) ([8956e28](8956e28)) * Optimizer to keep track of changing opcode locations (noir-lang/noir#6781) ([8956e28](8956e28)) * Race condition in block stream ([#10779](#10779)) ([64bccd0](64bccd0)) * Race condition when cleaning epoch proof quotes ([#10795](#10795)) ([f540fbe](f540fbe)) * **testdata:** Relative path calculation ([#10791](#10791)) ([5a530db](5a530db)) * Try fix e2e epochs in CI ([#10804](#10804)) ([ba28788](ba28788)) * Use correct size for databus_id ([#10673](#10673)) ([95eb658](95eb658)) * Use extension in docs link so it also works on GitHub (noir-lang/noir#6787) ([8956e28](8956e28)) * Use throw instead of reject in broker facade ([#10735](#10735)) ([cc6a72b](cc6a72b)) ### Miscellaneous * `getLogsByTags` request batching in `syncTaggedLogs` ([#10716](#10716)) ([bbbf38b](bbbf38b)) * Add `Instruction::map_values_mut` (noir-lang/noir#6756) ([308c5ce](308c5ce)) * Add errors to abis ([#10697](#10697)) ([5c8e017](5c8e017)) * Add retries for prover node p2p test ([#10699](#10699)) ([4115bf9](4115bf9)) * Add spans to proving job ([#10794](#10794)) ([df3c51b](df3c51b)) * Average alerts across namespace for 1 hour ([#10827](#10827)) ([962a7a2](962a7a2)) * **avm:** Disable fake avm recursive verifier from the public base rollup ([#10690](#10690)) ([b6c9c41](b6c9c41)) * **avm:** Radix opcode - remove immediates ([#10696](#10696)) ([4ac13e6](4ac13e6)), closes [#10371](#10371) * Better reqresp logging + handle empty responses in snappy ([#10657](#10657)) ([934107f](934107f)) * Bump metrics and node pool ([#10745](#10745)) ([9bb88bf](9bb88bf)) * Change Id to use a u32 (noir-lang/noir#6807) ([d74d0fc](d74d0fc)) * **ci:** Active rollup circuits in compilation report (noir-lang/noir#6813) ([308c5ce](308c5ce)) * **ci:** Add bloblib to external checks (noir-lang/noir#6818) ([381b0b8](381b0b8)) * Cleanup after e2e tests ([#10748](#10748)) ([284b0a4](284b0a4)) * Disable ARM CI ([#10682](#10682)) ([b16945b](b16945b)) * Do not print entire functions when running debug trace (noir-lang/noir#6814) ([308c5ce](308c5ce)) * **docs:** Update migration notes ([#10829](#10829)) ([be7cadf](be7cadf)) * **docs:** Workaround (noir-lang/noir#6819) ([381b0b8](381b0b8)) * Granular CLI imports to reduce start time ([#10778](#10778)) ([e2fd046](e2fd046)) * Log error in retry module ([#10719](#10719)) ([84ea539](84ea539)) * Manage call stacks using a tree (noir-lang/noir#6791) ([381b0b8](381b0b8)) * Move decider PK allocation to methods ([#10670](#10670)) ([1ab9e30](1ab9e30)) * **p2p:** Move services into folders ([#10694](#10694)) ([e28d12a](e28d12a)) * **prover:** Prover node should not gossip attestations ([#10672](#10672)) ([41fc0f0](41fc0f0)) * Remove default export for noir contracts js ([#10762](#10762)) ([c8e7763](c8e7763)) * Remove sinon in favor of a date provider ([#10705](#10705)) ([3d3fabb](3d3fabb)) * Remove spurious echo ([#10774](#10774)) ([5538f8c](5538f8c)) * Replace relative paths to noir-protocol-circuits ([f85fa3f](f85fa3f)) * Replace relative paths to noir-protocol-circuits ([b19c561](b19c561)) * Set max txs in spam test ([#10717](#10717)) ([a50ff6c](a50ff6c)) * Slack notifications for networks ([#10784](#10784)) ([bab9f85](bab9f85)) * Split up protocol contract artifacts ([#10765](#10765)) ([5a9ca18](5a9ca18)) * **ssa:** Activate loop invariant code motion on ACIR functions (noir-lang/noir#6785) ([8956e28](8956e28)) * Sync grafana dashboard ([#10792](#10792)) ([421fb65](421fb65)) * Tagging cleanup ([#10675](#10675)) ([52b541a](52b541a)) * Trace and handle errors in running promises ([#10645](#10645)) ([4cc0a6d](4cc0a6d)) * Update external joiner script for new networks ([#10810](#10810)) ([5f11cf4](5f11cf4)) </details> <details><summary>barretenberg: 0.67.1</summary> ## [0.67.1](barretenberg-v0.67.0...barretenberg-v0.67.1) (2024-12-17) ### Features * Add tree equality assertions ([#10756](#10756)) ([923826a](923826a)) * Better initialization for permutation mapping components ([#10750](#10750)) ([1516d7f](1516d7f)) * Don't store every block number in block indices DB ([#10658](#10658)) ([a3fba84](a3fba84)) * Leaf index requests to the native world state can now be performed as a batch query ([#10649](#10649)) ([a437e73](a437e73)) * New 17 in 20 IVC bench added to actions ([#10777](#10777)) ([9fbcff6](9fbcff6)) * Note hash management in the AVM ([#10666](#10666)) ([e077980](e077980)) * Sumcheck with disabled rows ([#10068](#10068)) ([abd2226](abd2226)) ### Bug Fixes * Avm gas and non-member ([#10709](#10709)) ([dd8cc7b](dd8cc7b)) * AVM witgen track gas for nested calls and external halts ([#10731](#10731)) ([b8bdb52](b8bdb52)) * Use correct size for databus_id ([#10673](#10673)) ([95eb658](95eb658)) ### Miscellaneous * **avm:** Radix opcode - remove immediates ([#10696](#10696)) ([4ac13e6](4ac13e6)), closes [#10371](#10371) * Move decider PK allocation to methods ([#10670](#10670)) ([1ab9e30](1ab9e30)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.67.1</summary> ## [0.67.1](AztecProtocol/aztec-packages@aztec-package-v0.67.0...aztec-package-v0.67.1) (2024-12-17) ### Miscellaneous * Granular CLI imports to reduce start time ([#10778](AztecProtocol/aztec-packages#10778)) ([e2fd046](AztecProtocol/aztec-packages@e2fd046)) * Split up protocol contract artifacts ([#10765](AztecProtocol/aztec-packages#10765)) ([5a9ca18](AztecProtocol/aztec-packages@5a9ca18)) * Trace and handle errors in running promises ([#10645](AztecProtocol/aztec-packages#10645)) ([4cc0a6d](AztecProtocol/aztec-packages@4cc0a6d)) </details> <details><summary>barretenberg.js: 0.67.1</summary> ## [0.67.1](AztecProtocol/aztec-packages@barretenberg.js-v0.67.0...barretenberg.js-v0.67.1) (2024-12-17) ### Features * PXE browser proving ([#10704](AztecProtocol/aztec-packages#10704)) ([46da3cc](AztecProtocol/aztec-packages@46da3cc)) ### Bug Fixes * **bb.js:** Use globalThis instead of self ([#10747](AztecProtocol/aztec-packages#10747)) ([309b5f7](AztecProtocol/aztec-packages@309b5f7)), closes [#10741](AztecProtocol/aztec-packages#10741) * Casting vk to rawbuffer before wasm so it reads from the correct offset ([#10769](AztecProtocol/aztec-packages#10769)) ([6a5bcfd](AztecProtocol/aztec-packages@6a5bcfd)) </details> <details><summary>aztec-packages: 0.67.1</summary> ## [0.67.1](AztecProtocol/aztec-packages@aztec-packages-v0.67.0...aztec-packages-v0.67.1) (2024-12-17) ### Features * `nargo test -q` (or `nargo test --format terse`) (noir-lang/noir#6776) ([8956e28](AztecProtocol/aztec-packages@8956e28)) * Add `(x | 1)` optimization for booleans (noir-lang/noir#6795) ([8956e28](AztecProtocol/aztec-packages@8956e28)) * Add `nargo test --format json` (noir-lang/noir#6796) ([d74d0fc](AztecProtocol/aztec-packages@d74d0fc)) * Add tree equality assertions ([#10756](AztecProtocol/aztec-packages#10756)) ([923826a](AztecProtocol/aztec-packages@923826a)) * **avm:** Migrate simulator memory to a map ([#10715](AztecProtocol/aztec-packages#10715)) ([64d5f2b](AztecProtocol/aztec-packages@64d5f2b)), closes [#10370](AztecProtocol/aztec-packages#10370) * Better initialization for permutation mapping components ([#10750](AztecProtocol/aztec-packages#10750)) ([1516d7f](AztecProtocol/aztec-packages@1516d7f)) * Blobs 2. ([#10188](AztecProtocol/aztec-packages#10188)) ([d0a4b2f](AztecProtocol/aztec-packages@d0a4b2f)) * **blobs:** Add consensus client url to config ([#10059](AztecProtocol/aztec-packages#10059)) ([1e15bf5](AztecProtocol/aztec-packages@1e15bf5)) * Check max fees per gas ([#10283](AztecProtocol/aztec-packages#10283)) ([4e59b06](AztecProtocol/aztec-packages@4e59b06)) * **cli:** Verify `return` against ABI and `Prover.toml` (noir-lang/noir#6765) ([8956e28](AztecProtocol/aztec-packages@8956e28)) * Don't store every block number in block indices DB ([#10658](AztecProtocol/aztec-packages#10658)) ([a3fba84](AztecProtocol/aztec-packages@a3fba84)) * Json output for get_node_info ([#10771](AztecProtocol/aztec-packages#10771)) ([b086c52](AztecProtocol/aztec-packages@b086c52)) * Leaf index requests to the native world state can now be performed as a batch query ([#10649](AztecProtocol/aztec-packages#10649)) ([a437e73](AztecProtocol/aztec-packages@a437e73)) * New 17 in 20 IVC bench added to actions ([#10777](AztecProtocol/aztec-packages#10777)) ([9fbcff6](AztecProtocol/aztec-packages@9fbcff6)) * Note hash management in the AVM ([#10666](AztecProtocol/aztec-packages#10666)) ([e077980](AztecProtocol/aztec-packages@e077980)) * **p2p:** Activate gossipsub tx validators ([#10695](AztecProtocol/aztec-packages#10695)) ([9cce2c6](AztecProtocol/aztec-packages@9cce2c6)) * **p2p:** Attestation pool persistence ([#10667](AztecProtocol/aztec-packages#10667)) ([dacef9f](AztecProtocol/aztec-packages@dacef9f)) * PXE browser proving ([#10704](AztecProtocol/aztec-packages#10704)) ([46da3cc](AztecProtocol/aztec-packages@46da3cc)) * **ssa:** Bring back tracking of RC instructions during DIE (noir-lang/noir#6783) ([308c5ce](AztecProtocol/aztec-packages@308c5ce)) * **ssa:** Hoist MakeArray instructions during loop invariant code motion (noir-lang/noir#6782) ([8956e28](AztecProtocol/aztec-packages@8956e28)) * Sumcheck with disabled rows ([#10068](AztecProtocol/aztec-packages#10068)) ([abd2226](AztecProtocol/aztec-packages@abd2226)) * TXE detects duplicate nullifiers ([#10764](AztecProtocol/aztec-packages#10764)) ([7f70110](AztecProtocol/aztec-packages@7f70110)) ### Bug Fixes * Always remove nullified notes ([#10722](AztecProtocol/aztec-packages#10722)) ([5e4b46d](AztecProtocol/aztec-packages@5e4b46d)) * Avm gas and non-member ([#10709](AztecProtocol/aztec-packages#10709)) ([dd8cc7b](AztecProtocol/aztec-packages@dd8cc7b)) * AVM witgen track gas for nested calls and external halts ([#10731](AztecProtocol/aztec-packages#10731)) ([b8bdb52](AztecProtocol/aztec-packages@b8bdb52)) * **bb.js:** Use globalThis instead of self ([#10747](AztecProtocol/aztec-packages#10747)) ([309b5f7](AztecProtocol/aztec-packages@309b5f7)), closes [#10741](AztecProtocol/aztec-packages#10741) * Block building test timeout ([#10812](AztecProtocol/aztec-packages#10812)) ([2cad3e5](AztecProtocol/aztec-packages@2cad3e5)) * Cache ([#10692](AztecProtocol/aztec-packages#10692)) ([1b1306c](AztecProtocol/aztec-packages@1b1306c)) * Casting vk to rawbuffer before wasm so it reads from the correct offset ([#10769](AztecProtocol/aztec-packages#10769)) ([6a5bcfd](AztecProtocol/aztec-packages@6a5bcfd)) * **ci:** Network-test timing ([#10725](AztecProtocol/aztec-packages#10725)) ([9c9a2dc](AztecProtocol/aztec-packages@9c9a2dc)) * Disable failure persistance in nargo test fuzzing (noir-lang/noir#6777) ([8956e28](AztecProtocol/aztec-packages@8956e28)) * Get e2e jobs ([#10689](AztecProtocol/aztec-packages#10689)) ([37e1999](AztecProtocol/aztec-packages@37e1999)) * Give build:fast a try in build ([#10702](AztecProtocol/aztec-packages#10702)) ([32095f6](AztecProtocol/aztec-packages@32095f6)) * Minimal change to avoid reverting entire PR [#6685](AztecProtocol/aztec-packages#6685) (noir-lang/noir#6778) ([8956e28](AztecProtocol/aztec-packages@8956e28)) * Optimizer to keep track of changing opcode locations (noir-lang/noir#6781) ([8956e28](AztecProtocol/aztec-packages@8956e28)) * Race condition in block stream ([#10779](AztecProtocol/aztec-packages#10779)) ([64bccd0](AztecProtocol/aztec-packages@64bccd0)) * Race condition when cleaning epoch proof quotes ([#10795](AztecProtocol/aztec-packages#10795)) ([f540fbe](AztecProtocol/aztec-packages@f540fbe)) * **testdata:** Relative path calculation ([#10791](AztecProtocol/aztec-packages#10791)) ([5a530db](AztecProtocol/aztec-packages@5a530db)) * Try fix e2e epochs in CI ([#10804](AztecProtocol/aztec-packages#10804)) ([ba28788](AztecProtocol/aztec-packages@ba28788)) * Use correct size for databus_id ([#10673](AztecProtocol/aztec-packages#10673)) ([95eb658](AztecProtocol/aztec-packages@95eb658)) * Use extension in docs link so it also works on GitHub (noir-lang/noir#6787) ([8956e28](AztecProtocol/aztec-packages@8956e28)) * Use throw instead of reject in broker facade ([#10735](AztecProtocol/aztec-packages#10735)) ([cc6a72b](AztecProtocol/aztec-packages@cc6a72b)) ### Miscellaneous * `getLogsByTags` request batching in `syncTaggedLogs` ([#10716](AztecProtocol/aztec-packages#10716)) ([bbbf38b](AztecProtocol/aztec-packages@bbbf38b)) * Add `Instruction::map_values_mut` (noir-lang/noir#6756) ([308c5ce](AztecProtocol/aztec-packages@308c5ce)) * Add errors to abis ([#10697](AztecProtocol/aztec-packages#10697)) ([5c8e017](AztecProtocol/aztec-packages@5c8e017)) * Add retries for prover node p2p test ([#10699](AztecProtocol/aztec-packages#10699)) ([4115bf9](AztecProtocol/aztec-packages@4115bf9)) * Add spans to proving job ([#10794](AztecProtocol/aztec-packages#10794)) ([df3c51b](AztecProtocol/aztec-packages@df3c51b)) * Average alerts across namespace for 1 hour ([#10827](AztecProtocol/aztec-packages#10827)) ([962a7a2](AztecProtocol/aztec-packages@962a7a2)) * **avm:** Disable fake avm recursive verifier from the public base rollup ([#10690](AztecProtocol/aztec-packages#10690)) ([b6c9c41](AztecProtocol/aztec-packages@b6c9c41)) * **avm:** Radix opcode - remove immediates ([#10696](AztecProtocol/aztec-packages#10696)) ([4ac13e6](AztecProtocol/aztec-packages@4ac13e6)), closes [#10371](AztecProtocol/aztec-packages#10371) * Better reqresp logging + handle empty responses in snappy ([#10657](AztecProtocol/aztec-packages#10657)) ([934107f](AztecProtocol/aztec-packages@934107f)) * Bump metrics and node pool ([#10745](AztecProtocol/aztec-packages#10745)) ([9bb88bf](AztecProtocol/aztec-packages@9bb88bf)) * Change Id to use a u32 (noir-lang/noir#6807) ([d74d0fc](AztecProtocol/aztec-packages@d74d0fc)) * **ci:** Active rollup circuits in compilation report (noir-lang/noir#6813) ([308c5ce](AztecProtocol/aztec-packages@308c5ce)) * **ci:** Add bloblib to external checks (noir-lang/noir#6818) ([381b0b8](AztecProtocol/aztec-packages@381b0b8)) * Cleanup after e2e tests ([#10748](AztecProtocol/aztec-packages#10748)) ([284b0a4](AztecProtocol/aztec-packages@284b0a4)) * Disable ARM CI ([#10682](AztecProtocol/aztec-packages#10682)) ([b16945b](AztecProtocol/aztec-packages@b16945b)) * Do not print entire functions when running debug trace (noir-lang/noir#6814) ([308c5ce](AztecProtocol/aztec-packages@308c5ce)) * **docs:** Update migration notes ([#10829](AztecProtocol/aztec-packages#10829)) ([be7cadf](AztecProtocol/aztec-packages@be7cadf)) * **docs:** Workaround (noir-lang/noir#6819) ([381b0b8](AztecProtocol/aztec-packages@381b0b8)) * Granular CLI imports to reduce start time ([#10778](AztecProtocol/aztec-packages#10778)) ([e2fd046](AztecProtocol/aztec-packages@e2fd046)) * Log error in retry module ([#10719](AztecProtocol/aztec-packages#10719)) ([84ea539](AztecProtocol/aztec-packages@84ea539)) * Manage call stacks using a tree (noir-lang/noir#6791) ([381b0b8](AztecProtocol/aztec-packages@381b0b8)) * Move decider PK allocation to methods ([#10670](AztecProtocol/aztec-packages#10670)) ([1ab9e30](AztecProtocol/aztec-packages@1ab9e30)) * **p2p:** Move services into folders ([#10694](AztecProtocol/aztec-packages#10694)) ([e28d12a](AztecProtocol/aztec-packages@e28d12a)) * **prover:** Prover node should not gossip attestations ([#10672](AztecProtocol/aztec-packages#10672)) ([41fc0f0](AztecProtocol/aztec-packages@41fc0f0)) * Remove default export for noir contracts js ([#10762](AztecProtocol/aztec-packages#10762)) ([c8e7763](AztecProtocol/aztec-packages@c8e7763)) * Remove sinon in favor of a date provider ([#10705](AztecProtocol/aztec-packages#10705)) ([3d3fabb](AztecProtocol/aztec-packages@3d3fabb)) * Remove spurious echo ([#10774](AztecProtocol/aztec-packages#10774)) ([5538f8c](AztecProtocol/aztec-packages@5538f8c)) * Replace relative paths to noir-protocol-circuits ([f85fa3f](AztecProtocol/aztec-packages@f85fa3f)) * Replace relative paths to noir-protocol-circuits ([b19c561](AztecProtocol/aztec-packages@b19c561)) * Set max txs in spam test ([#10717](AztecProtocol/aztec-packages#10717)) ([a50ff6c](AztecProtocol/aztec-packages@a50ff6c)) * Slack notifications for networks ([#10784](AztecProtocol/aztec-packages#10784)) ([bab9f85](AztecProtocol/aztec-packages@bab9f85)) * Split up protocol contract artifacts ([#10765](AztecProtocol/aztec-packages#10765)) ([5a9ca18](AztecProtocol/aztec-packages@5a9ca18)) * **ssa:** Activate loop invariant code motion on ACIR functions (noir-lang/noir#6785) ([8956e28](AztecProtocol/aztec-packages@8956e28)) * Sync grafana dashboard ([#10792](AztecProtocol/aztec-packages#10792)) ([421fb65](AztecProtocol/aztec-packages@421fb65)) * Tagging cleanup ([#10675](AztecProtocol/aztec-packages#10675)) ([52b541a](AztecProtocol/aztec-packages@52b541a)) * Trace and handle errors in running promises ([#10645](AztecProtocol/aztec-packages#10645)) ([4cc0a6d](AztecProtocol/aztec-packages@4cc0a6d)) * Update external joiner script for new networks ([#10810](AztecProtocol/aztec-packages#10810)) ([5f11cf4](AztecProtocol/aztec-packages@5f11cf4)) </details> <details><summary>barretenberg: 0.67.1</summary> ## [0.67.1](AztecProtocol/aztec-packages@barretenberg-v0.67.0...barretenberg-v0.67.1) (2024-12-17) ### Features * Add tree equality assertions ([#10756](AztecProtocol/aztec-packages#10756)) ([923826a](AztecProtocol/aztec-packages@923826a)) * Better initialization for permutation mapping components ([#10750](AztecProtocol/aztec-packages#10750)) ([1516d7f](AztecProtocol/aztec-packages@1516d7f)) * Don't store every block number in block indices DB ([#10658](AztecProtocol/aztec-packages#10658)) ([a3fba84](AztecProtocol/aztec-packages@a3fba84)) * Leaf index requests to the native world state can now be performed as a batch query ([#10649](AztecProtocol/aztec-packages#10649)) ([a437e73](AztecProtocol/aztec-packages@a437e73)) * New 17 in 20 IVC bench added to actions ([#10777](AztecProtocol/aztec-packages#10777)) ([9fbcff6](AztecProtocol/aztec-packages@9fbcff6)) * Note hash management in the AVM ([#10666](AztecProtocol/aztec-packages#10666)) ([e077980](AztecProtocol/aztec-packages@e077980)) * Sumcheck with disabled rows ([#10068](AztecProtocol/aztec-packages#10068)) ([abd2226](AztecProtocol/aztec-packages@abd2226)) ### Bug Fixes * Avm gas and non-member ([#10709](AztecProtocol/aztec-packages#10709)) ([dd8cc7b](AztecProtocol/aztec-packages@dd8cc7b)) * AVM witgen track gas for nested calls and external halts ([#10731](AztecProtocol/aztec-packages#10731)) ([b8bdb52](AztecProtocol/aztec-packages@b8bdb52)) * Use correct size for databus_id ([#10673](AztecProtocol/aztec-packages#10673)) ([95eb658](AztecProtocol/aztec-packages@95eb658)) ### Miscellaneous * **avm:** Radix opcode - remove immediates ([#10696](AztecProtocol/aztec-packages#10696)) ([4ac13e6](AztecProtocol/aztec-packages@4ac13e6)), closes [#10371](AztecProtocol/aztec-packages#10371) * Move decider PK allocation to methods ([#10670](AztecProtocol/aztec-packages#10670)) ([1ab9e30](AztecProtocol/aztec-packages@1ab9e30)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Minimal change to avoid reverting entire PR

d20cde8

jfecher requested a review from a team December 11, 2024 20:29

TomAFrench added the run-external-checks Trigger CI job to run tests on external repos label Dec 11, 2024

Update expected rc

e2c72b9

jfecher mentioned this pull request Dec 11, 2024

chore: revert #6685 #6774

Closed

5 tasks

asterite approved these changes Dec 11, 2024

View reviewed changes

format

85fb214

TomAFrench approved these changes Dec 12, 2024

View reviewed changes

TomAFrench added this pull request to the merge queue Dec 12, 2024

Merged via the queue into master with commit 0925a33 Dec 12, 2024
78 of 81 checks passed

TomAFrench deleted the jf/revert-6685 branch December 12, 2024 11:46

noirwhal mentioned this pull request Dec 12, 2024

chore: Release Noir(1.0.0-beta.1) #6622

Merged

AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 12, 2024

[1 changes] fix: Minimal change to avoid reverting entire PR #6685 (n…

e4443e6

…oir-lang/noir#6778)

AztecBot mentioned this pull request Dec 12, 2024

feat: Sync from noir AztecProtocol/aztec-packages#10660

Merged

AztecBot mentioned this pull request Dec 13, 2024

chore(master): Release 0.67.1 AztecProtocol/aztec-packages#10684

Merged

AztecBot mentioned this pull request Dec 17, 2024

chore(master): Release 0.67.1 AztecProtocol/aztec-packages#10708

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Minimal change to avoid reverting entire PR #6685 #6778

fix: Minimal change to avoid reverting entire PR #6685 #6778

jfecher commented Dec 11, 2024

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

TomAFrench commented Dec 11, 2024

fix: Minimal change to avoid reverting entire PR #6685 #6778

fix: Minimal change to avoid reverting entire PR #6685 #6778

Conversation

jfecher commented Dec 11, 2024

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

github-actions bot commented Dec 11, 2024 • edited Loading

Changes to Brillig bytecode sizes

🧾 Summary (10% most significant diffs)

github-actions bot commented Dec 11, 2024 • edited Loading

Peak Memory Sample

github-actions bot commented Dec 11, 2024 • edited Loading

Compilation Sample

github-actions bot commented Dec 11, 2024 • edited Loading

Changes to number of Brillig opcodes executed

🧾 Summary (10% most significant diffs)

TomAFrench commented Dec 11, 2024

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading