Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ssa): Predicate for store instruction #829

Merged
merged 9 commits into from
Feb 14, 2023
Merged

chore(ssa): Predicate for store instruction #829

merged 9 commits into from
Feb 14, 2023

Conversation

guipublic
Copy link
Contributor

Description

Summary of changes

This is the third preparation PR for dynamic arrays. It adds a predicate for store instructions, which avoids inserting a dummy load instruction for each store under condition. We add it back at gate generation when the index is constant, whereas non-const index will not need it.

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

jfecher
jfecher approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kevaundray kevaundray added this pull request to the merge queue Feb 14, 2023
Merged via the queue into master with commit 210b83e Feb 14, 2023
@kevaundray kevaundray deleted the gd/dynamic_array3 branch February 14, 2023 19:35
TomAFrench added a commit that referenced this pull request Feb 15, 2023
@TomAFrench
Merge branch 'master' into abi-to-witness-map
9630143 
* master:
  chore(ssa): Predicate for store instruction (#829)
  feat(std_lib): println statements (#630)
  chore(ci): Make Kev the committer on release lockfile updates (#845)
  feat(stdlib): Add higher order array functions (#833)
  chore(ssa): Remove values from array type (#771)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray left review comments

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guipublic @jfecher @kevaundray