Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Make Kev the committer on release lockfile updates #845

Merged
merged 1 commit into from
Feb 14, 2023
Merged

chore(ci): Make Kev the committer on release lockfile updates #845

merged 1 commit into from
Feb 14, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Feb 14, 2023

Related issue(s)

Follow up to #840

Description

We were triggering the builds on the PR itself, but the push of the lockfile was not running checks and blocking the merge. This adds the token to checkout the repo & push the new lockfile as @kevaundray so CI will run. Tested on my fork.

Summary of changes

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

@kevaundray
Copy link
Contributor

@phated For reference and for the future, we will create a noir-bot that does this?

@phated
Copy link
Contributor Author

phated commented Feb 14, 2023 •
edited
Loading

For reference and for the future, we will create a noir-bot that does this?

Yep! I'd love to create the bot now but we need to figure out who will control it so we can secure it correctly

@kevaundray kevaundray added this pull request to the merge queue Feb 14, 2023
Merged via the queue into master with commit 0108ac6 Feb 14, 2023
@kevaundray kevaundray deleted the phated/release-committer branch February 14, 2023 18:08
TomAFrench added a commit that referenced this pull request Feb 15, 2023
@TomAFrench
Merge branch 'master' into abi-to-witness-map
9630143 
* master:
  chore(ssa): Predicate for store instruction (#829)
  feat(std_lib): println statements (#630)
  chore(ci): Make Kev the committer on release lockfile updates (#845)
  feat(stdlib): Add higher order array functions (#833)
  chore(ssa): Remove values from array type (#771)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

@kobyhallx kobyhallx Awaiting requested review from kobyhallx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phated @kevaundray