-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compile): Noir std lib embedded #973
Conversation
|
agreed, should be refactored to more common path at later stage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I've run a quick test locally just to confirm that we're actually pulling the stdlib from an embedded version and all looks good.
unnecessary after noir-lang/noir#973
unnecessary after noir-lang/noir#973
Related issue(s)
Relates to #951
Description
It's beneficial to embed std lib into distributed binary:
Summary of changes
noir_stdlib/src
contents get embedded asStdLibAssets
incrates/fm/src/file_reader.rs
StdLibAssets
is asked for source upfront duringread_file_to_string
routinecrates/nargo/src/cli/mod.rs
understands thatStdLibAssets
are embedded withstd/
prefix and adds such search path forcreate_non_local_crate
routine.Dependency additions / changes
Adds
rust-embed = "6.6.0"
Test additions / changes
N/A
Checklist
cargo fmt
with default settings.Documentation needs
Additional context
n/a