Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: automatically inject stdlib when resolving crate #998

Merged
merged 1 commit into from
Mar 18, 2023

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Mar 17, 2023

Related issue(s)

Addresses #973 (comment)

Description

Summary of changes

Currently we need to remember to explicitly add the std lib whenever we resolve a crate. Instead of this I've merged this into Resolver::resolve_root_config to happen automatically.

The wasm crate still has to add the stdlib manually as it doesn't use the Resolver

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@TomAFrench TomAFrench requested a review from kobyhallx March 17, 2023 13:13
@kevaundray kevaundray added this pull request to the merge queue Mar 18, 2023
@kevaundray kevaundray merged commit 8a97336 into noir-lang:master Mar 18, 2023
@TomAFrench TomAFrench deleted the push-std-lib-into-resolver branch March 18, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants