Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace automated script with manual install steps to fix data loss #12

Closed
arcticicestudio opened this issue Apr 8, 2020 · 0 comments · Fixed by #13
Closed

Replace automated script with manual install steps to fix data loss #12

arcticicestudio opened this issue Apr 8, 2020 · 0 comments · Fixed by #13
Labels
context-api priority-critical scope-quality scope-security scope-ux type-bug
Milestone
version-next

Comments

@arcticicestudio
Copy link
Collaborator

arcticicestudio commented Apr 8, 2020 •
edited
Loading

Remove installation script to fix possible data loss

@TolichP reported in #3 (comment) that the install.sh script currently replaces the config file which can lead to configuration/data loss. This is caused by the -f flag passed to the cp command which forces to override existing files.

This is a really critical bug and the the solution to provide a script that automatically handles the simple task of copying a file has never been a good idea at all. Therefore the script will be removed and the documentation will be adjusted to provide manual installation steps instead like in other port projects, e.g. Nord Alacritty. The manual steps are quite simple and the knowledge can be expected of users since these are basic operations when running a Unix system.

Projects like Terminator, that require to modify the main user configuration file instead of providing a way to load features like themes from dedicated file, are always way harder to support as a theme author. Anyway, there are plans to unify the installation of Nord port projects through one universal automation tool, but there is currently no ETA.
@arcticicestudio arcticicestudio added this to the 0.2.0 milestone Apr 8, 2020
@arcticicestudio arcticicestudio changed the title Remove installation script to fix possible data loss Replace automated script with manual install steps to fix data loss Apr 8, 2020
arcticicestudio added a commit that referenced this issue Apr 8, 2020
@arcticicestudio
Replace automated script with manual install steps to fix data loss
5ea80a4 
@TolichP [1] reported in #3 [2
`install.sh` script replaced the `config` file which led to
configuration/data loss. This was caused by the `-f` flag passed to the
`cp` command [3] which forced to override existing files.

This is a really critical bug and the the solution to provide a script
that automatically handles the simple task of copying a file has never
been a good idea at all. Therefore the script was removed and the
documentation has been adjusted to provide manual installation steps
instead like in other port projects, e.g. Nord Alacritty [4].
The manual steps are quite simple and the knowledge can be expected of
users since these are basic operations when running a Unix system.

Projects like Terminato, that require to modify the main user
configuration file instead of providing a way to load features like
themes from dedicated file, are always way harder to support as a
theme author. Anyway, there are plans to unify the installation of Nord
port projects through one universal automation tool,
but there is currently no ETA.

[1]: https://github.com/TolichP
[2]: #3 (comment)
[3]: https://github.com/arcticicestudio/nord-terminator/blob/af29e150a531f7984d362f4aa135c1bfffd13c45/install.sh#L83
[4]: https://github.com/arcticicestudio/nord-alacritty

GH-12
@arcticicestudio arcticicestudio mentioned this issue Apr 8, 2020
Merged
arcticicestudio added a commit that referenced this issue Apr 8, 2020
@arcticicestudio
Replace automated script with manual install steps to fix data loss (#13
a4b201a 
)

@TolichP [1] reported in #3 [2
`install.sh` script replaced the `config` file which led to
configuration/data loss. This was caused by the `-f` flag passed to the
`cp` command [3] which forced to override existing files.

This is a really critical bug and the the solution to provide a script
that automatically handles the simple task of copying a file has never
been a good idea at all. Therefore the script was removed and the
documentation has been adjusted to provide manual installation steps
instead like in other port projects, e.g. Nord Alacritty [4].
The manual steps are quite simple and the knowledge can be expected of
users since these are basic operations when running a Unix system.

Projects like Terminato, that require to modify the main user
configuration file instead of providing a way to load features like
themes from dedicated file, are always way harder to support as a
theme author. Anyway, there are plans to unify the installation of Nord
port projects through one universal automation tool,
but there is currently no ETA.

[1]: https://github.com/TolichP
[2]: #3 (comment)
[3]: https://github.com/arcticicestudio/nord-terminator/blob/af29e150a531f7984d362f4aa135c1bfffd13c45/install.sh#L83
[4]: https://github.com/arcticicestudio/nord-alacritty

Fixes GH-12
@arcticicestudio arcticicestudio mentioned this issue Apr 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-api priority-critical scope-quality scope-security scope-ux type-bug
Projects
None yet
Milestone
version-next
Development

Successfully merging a pull request may close this issue.

Replace automated script with manual install steps to fix data loss nordtheme/terminator
2 participants
@arcticicestudio @svengreb