Replace automated script with manual install steps to fix data loss #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
arcticicestudio
commented
Apr 8, 2020
•
arcticicestudio
commented
@TolichP [1] reported in #3 [2 `install.sh` script replaced the `config` file which led to configuration/data loss. This was caused by the `-f` flag passed to the `cp` command [3] which forced to override existing files. This is a really critical bug and the the solution to provide a script that automatically handles the simple task of copying a file has never been a good idea at all. Therefore the script was removed and the documentation has been adjusted to provide manual installation steps instead like in other port projects, e.g. Nord Alacritty [4]. The manual steps are quite simple and the knowledge can be expected of users since these are basic operations when running a Unix system. Projects like Terminato, that require to modify the main user configuration file instead of providing a way to load features like themes from dedicated file, are always way harder to support as a theme author. Anyway, there are plans to unify the installation of Nord port projects through one universal automation tool, but there is currently no ETA. [1]: https://github.com/TolichP [2]: #3 (comment) [3]: https://github.com/arcticicestudio/nord-terminator/blob/af29e150a531f7984d362f4aa135c1bfffd13c45/install.sh#L83 [4]: https://github.com/arcticicestudio/nord-alacritty GH-12
svengreb
approved these changes
Apr 8, 2020
This was referenced Apr 8, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.