Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Husky #18

Closed
2 tasks done
arcticicestudio opened this issue Nov 17, 2018 · 0 comments
Closed
2 tasks done

Husky #18

arcticicestudio opened this issue Nov 17, 2018 · 0 comments
Labels
context-workflow scope-maintainability type-feature
Milestone
0.1.0

Comments

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Nov 17, 2018 •
edited
Loading

Must be resolved after #17

Integrate Husky, the tool that make Git hooks easy and can prevent bad Git commits, pushes and more 🐶 woof!

Configuration

The configuration file .huskyrc.js will be placed in the project root and includes the command to run for any supported Git hook. It will at least contain configs for the following hooks:

  • pre-commit - Run lint-staged (lint-staged #17) before each commit (via lint-staged command) to ensure all staged files are compliant to all style guides.

Tasks

  • Install husky package.
  • Implement .huskyrc.js configuration file.
@arcticicestudio arcticicestudio added this to the 0.1.0 milestone Nov 17, 2018
@arcticicestudio arcticicestudio self-assigned this Nov 17, 2018
@arcticicestudio arcticicestudio mentioned this issue Nov 17, 2018
Closed
2 tasks
arcticicestudio added a commit that referenced this issue Nov 17, 2018
@arcticicestudio
Install "husky" package
d2e8c94 
Installed Husky, the tool that make Git hooks easy and can prevent bad
Git commits, pushes and more!

GH-18
arcticicestudio added a commit that referenced this issue Nov 17, 2018
@arcticicestudio
Ensure remark-lint runs on ".github" files
8b21100 
The files are currently not included and might bypass the Git hooks.
This commit updates the "lint:md" command to ensure the files are
included when linting.

GH-18
arcticicestudio added a commit that referenced this issue Nov 17, 2018
@arcticicestudio
Initial run with lint-staged Git hooks triggered through Husky
749e01f 
This commit includes the fixed style guide volations that have been
found after the initial run of the "lint-staged" Git hooks triggered by
Husky.

GH-18
@arcticicestudio arcticicestudio mentioned this issue Nov 17, 2018
Merged
arcticicestudio added a commit that referenced this issue Nov 17, 2018
@arcticicestudio
Merge pull request #23 from arcticicestudio/task/gh-18-husky
16e90c3 
Integrated Husky (1), the tool that make Git hooks easy and can prevent
bad Git commits, pushes and more 🐶 _woof_!

>> Configuration

The configuration file `.huskyrc.js` has been placed in the project root
and includes the commands to run for any supported Git hook (2). It will
at least contain configs for the following hooks:

- `pre-commit` - Run lint-staged (GH-17) before each commit (via
  `lint-staged` command) to ensure all staged files are compliant to all
  style guides.

References:

  (1)https://github.com/typicode/husky
  (2) https://github.com/typicode/husky/blob/master/DOCS.md#supported-hooks
  (3) https://github.com/typicode/husky/blob/master/DOCS.md#supported-hooks
@arcticicestudio arcticicestudio removed their assignment Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-workflow scope-maintainability type-feature
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
1 participant
@arcticicestudio