Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Husky #23

Merged
merged 4 commits into from
Nov 17, 2018
Merged

Husky #23

merged 4 commits into from
Nov 17, 2018

Conversation

arcticicestudio
Copy link
Contributor

Closes GH-18

@arcticicestudio
Install "husky" package
d2e8c94 
Installed Husky, the tool that make Git hooks easy and can prevent bad
Git commits, pushes and more!

GH-18
@arcticicestudio
Implement Husky configuration
8c79276 
The `.huskyrc.js` file is placed in the project root and includes the
commands to run for any supported Git hook (1). This commits initially
adds configs for the following hook:

- `pre-commit` - Run lint-staged (GH-17) before each commit (via
  `lint-staged` command) to ensure all staged files are compliant to
  all style guides.

References:

  (1) https://github.com/typicode/husky/blob/master/DOCS.md#supported-hooks
@arcticicestudio
Ensure remark-lint runs on ".github" files
8b21100 
The files are currently not included and might bypass the Git hooks.
This commit updates the "lint:md" command to ensure the files are
included when linting.

GH-18
@arcticicestudio
Initial run with lint-staged Git hooks triggered through Husky
749e01f 
This commit includes the fixed style guide volations that have been
found after the initial run of the "lint-staged" Git hooks triggered by
Husky.

GH-18
@arcticicestudio arcticicestudio added this to the 0.1.0 milestone Nov 17, 2018
@arcticicestudio arcticicestudio self-assigned this Nov 17, 2018
@arcticicestudio arcticicestudio merged commit 16e90c3 into develop Nov 17, 2018
@arcticicestudio arcticicestudio deleted the task/gh-18-husky branch November 17, 2018 19:34
@arcticicestudio arcticicestudio removed their assignment Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svengreb svengreb svengreb approved these changes

Assignees
No one assigned
Labels
context-workflow scope-maintainability type-feature
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@arcticicestudio @svengreb