Fixing old and dummy nodes registering #4157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, the module was not registering any old node classes during reload event
…ing event (F8, script.reload), some functions had ridiculous logic, mistakes in function descriptions
…ees before 2018. To keep the code does not have sense because in 2018 backward compatibility with old node trees was broken. Now nodes should have `load_file_update` method if they want to fix something upon loading a file.
…e to do this but it will let to keep our update system simpler.
…r this calls as really fragile solution to update nodes content after loading a file even if it looks like proper approach. It will let to keep our update system simpler and don't think how this should be handled during importing JSON files.
…gister # Conflicts: # core/__init__.py # core/handlers.py # old_nodes/__init__.py
… handling_nodes.py. During initialization (second time) they was tried to be registered two times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed problem description
Fixes #4133
Closes #4148
Solution is to register all old and dummy nodes for now if there is at least one node with unregistered class in a loaded file.
Also after reloading Sverchok (F8) all old and dummy nodes will be registered. It even impossible to check whether there are nodes with unregistered classes because during reloading event it may happened that even normal node classes was not registered yet. Delegate finishing Sverchok initialization to update system (as it is before this PR) I consider as wrong solution. Update system should either update node trees or finish Sverchok initialization after reload event (according its name, the first would be more expected I think).
There is no
upgrade nodesmodule any morebut there isIf you want to update a node content do this in the process method. It does not look like appropriate place but this will let to keep our update system simpler and this will work for both loading a new file and importing a JSON.load_file_updateoptional method for nodes. I did not finish with its implementation yet (I secretly wish not implement it at all). Probably it should be called not only when file is loded but also when trees are imported via JSON format.Trees will be properly updated after reload event even if first tree update was not properly throttled.
Found a lot of strange things in refactored modules.
Preflight checklist
- [ ] Think about theload_file_updatemethod