Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing old and dummy nodes registering #4157

Merged
merged 11 commits into from
Jun 11, 2021
Merged

Commits on Jun 9, 2021

  1. Configuration menu
    Copy the full SHA
    178a485 View commit details
    Browse the repository at this point in the history
  2. refactoring old nodes module, add logic of registering all old nodes…

    …, the module was not registering any old node classes during reload event
    Durman committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    073b9f4 View commit details
    Browse the repository at this point in the history
  3. refactoring dummy nodes module, the module was not reacting on reload…

    …ing event (F8, script.reload), some functions had ridiculous logic, mistakes in function descriptions
    Durman committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    fd7ab9e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1c5f755 View commit details
    Browse the repository at this point in the history
  5. remove upgrade nodes module, most code was related with saved node tr…

    …ees before 2018. To keep the code does not have sense because in 2018 backward compatibility with old node trees was broken. Now nodes should have `load_file_update` method if they want to fix something upon loading a file.
    Durman committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    f5af8d3 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2021

  1. move update upon file loading to process method. It is not great plac…

    …e to do this but it will let to keep our update system simpler.
    Durman committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    9ef642f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    42d35a9 View commit details
    Browse the repository at this point in the history
  3. add errors catching and remove calling of load file update. I conside…

    …r this calls as really fragile solution to update nodes content after loading a file even if it looks like proper approach. It will let to keep our update system simpler and don't think how this should be handled during importing JSON files.
    Durman committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    85aa264 View commit details
    Browse the repository at this point in the history
  4. Merge remote-tracking branch 'origin/master' into fixing_old_nodes_re…

    …gister
    
    # Conflicts:
    #	core/__init__.py
    #	core/handlers.py
    #	old_nodes/__init__.py
    Durman committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    bf3d8ae View commit details
    Browse the repository at this point in the history
  5. fixing the JSON example file

    Durman committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    e436159 View commit details
    Browse the repository at this point in the history
  6. fixing problem of registering old nodes which uses the decorator from…

    … handling_nodes.py. During initialization (second time) they was tried to be registered two times
    Durman committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    c8e9b80 View commit details
    Browse the repository at this point in the history