Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scene handler #4299

Merged
merged 6 commits into from
May 6, 2022
Merged

Scene handler #4299

merged 6 commits into from
May 6, 2022

Conversation

Durman
Copy link
Collaborator

@Durman Durman commented Aug 20, 2021

Addressed problem description

Closes #4283. It should update nodes reading data from Blender upon changes in the scene.
I feel this make work with Sverchok more comfortable in case when workflow include reading data from Blender.
Update live operator can be removed.

2021-08-20_19-14-56

Preflight checklist

  • Code changes complete.
  • Code documentation complete.
  • Documentation for users complete.
  • Manual testing done.
  • Ready for merge.

should update nodes reading data from Blender upon changes in the scene
@Durman Durman added the core Architectural problems label Aug 20, 2021
@Durman Durman marked this pull request as draft August 27, 2021 17:24
…property instead. Also add is_scene_dependent property which handled nodes to be updated upon user changes in scene
@Durman
Copy link
Collaborator Author

Durman commented Aug 28, 2021

I removed AnimatableNode class. Now it's possible make a node to be animatble in this way.

class Node:
    is_animation_dependent = True

Also, instead of draw_buttons, sv_draw_buttons should be used now. It will let to draw extra buttons in the node UI.

Also it's possible to add is_scene_dependent = True property. In this case the node will be update on user changes in the scene.

@Durman Durman marked this pull request as ready for review May 5, 2022 06:43
@Durman Durman merged commit 6019f8e into master May 6, 2022
@Durman Durman deleted the scene_handler branch May 6, 2022 07:07
@rendetto
Copy link
Contributor

rendetto commented May 8, 2022

I just did a quick test on one of my heaviest scenes and it works perfect.
Great solution that makes a ton of difference for my workflow.

Thank you @Durman!

@Durman
Copy link
Collaborator Author

Durman commented May 8, 2022

@rendetto I'm glad that it's useful =)

@rendetto rendetto mentioned this pull request Jun 9, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Architectural problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Live update operator
2 participants