Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Borders are not working in Firefox #250

Closed
guastallaigor opened this issue Jan 16, 2019 · 3 comments · Fixed by #261
Closed

Bug: Borders are not working in Firefox #250

guastallaigor opened this issue Jan 16, 2019 · 3 comments · Fixed by #261
Assignees
Labels
bug Something isn't working released

Comments

@guastallaigor
Copy link
Member

guastallaigor commented Jan 16, 2019

This bug was founded by @juanpablolvl99. I tested it myself and it is happening.

Describe the bug
Pixelated borders are not working in Mozilla Firefox in the develop branch.

To Reproduce
Steps to reproduce the behavior:

  1. Clone the repository;
  2. Run npm install;
  3. Run npm run build;
  4. Run npm run storybook;
  5. Click in the Inputs or Buttons or Selects or Textareas or Progress menu inside the sidebar;
  6. You will be able to see that the borders are not showing, even if you change the options to is-success, or is-warning or is-error;

Expected behavior
The borders are pixelated and when I click an option it changes the color.

Screenshots

image

image

image

image

Environment:

  • OS: Ubuntu 16.04
  • Browser: Firefox Developer Edition 65.0b11 (64-bit) / Firefox Quantum 64.0 (64-bit) (test it on both)
  • Build environment Node v10.15.0

Suggestion(s) for fixing this issue
Maybe the border-image property does not work in Firefox?

Additional context
In master this is not happening in any of the browsers.

@guastallaigor guastallaigor added the bug Something isn't working label Jan 16, 2019
@guastallaigor guastallaigor changed the title Bug: Borders not working on firefox Bug: Borders are not working in Firefox Jan 16, 2019
This was referenced Jan 18, 2019
@BcRikko
Copy link
Member

BcRikko commented Jan 23, 2019

Maybe this is related to #234

bug ???
bug fill

I don't know why but it seems that it will not be working when using HEX color codes. 🤔

@BcRikko BcRikko self-assigned this Jan 28, 2019
@BcRikko
Copy link
Member

BcRikko commented Jan 29, 2019

WooHoo, I got it!! 🎉
I'll create Pull Request later. 👍
2019-01-29 16 10 11
border

fill="rgb(#{red($color)}, #{green($color)}, #{blue($color)})"

// I could not use 'rgba' function. Because like this:
rgba(#ff0000, 1.0) -> #ff0000

BcRikko added a commit that referenced this issue Jan 29, 2019
borders does not working on firefox

fix #250
BcRikko added a commit that referenced this issue Jan 30, 2019
@BcRikko
Copy link
Member

BcRikko commented Feb 16, 2019

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants