Release v1.1.0 #252
Merged
Release v1.1.0 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dialog styles added by @sophi-est weren't being loaded into the compiled stylesheet. I've added them to the elements index file and moved the rounded corners styles into and `.is-rounded` modifier class.
We no longer need to build the entire framework to lint it, so I've removed the build step from the pre-commit hook and replaced it with just stylelint.
perf: Speed up pre-commit hooks
Fix: mario icon on index.html and one line indent
Fix contributing links in all of the readmes
Previously, we were using the `color` property to determine the color of the border around `<dialog />` elements. The issue with this is that it requires the text color to match the border color. I've fixed this by moving the border color declarations into the `box-shadow` property.
fix(dialog): Fix dialog corners
perf: icon shadow optimization
Use remove width, height and transform properties and use font-size to adjust #pixelize output. #152
Removed box-sizing and border none, and classes that changed the size. Added cursor fallback and size change by the font-size. Changed from span to a; display type; margin. #211
Feat/add coin icon
feat(icons): add psone controller icon
border is not visible when opening dark dialog
…css into add-text-and-dialog-to-docs
…oller-icon Revert "feat(icons): add psone controller icon"
feat(index.html): add dialogs/texts to index. changed table to tables
guastallaigor
removed
the
waiting - contributor
This reverts commit 361b2c2.
BREAKING CHANGE: fix field class to nes-field
Merged
Edit message of #229
feat: make all variables default
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending to release
Issues:
emon Chrome #262 - Bug: Icon less than 10px on ChromePRs:
Personal thoughts
Those three bugs are a regression in the framework.
In my opinion we can not make another release until those are resolved.
I tried a few things but couldn't make it work like it was before.
I can revert some of it but that's pretty much it. Would like to hear some thoughts in this.
Edit: Waiting corrections are going to be in 1.2.0+.