Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version and changelog for 0.4 #910

Merged
merged 4 commits into from
Sep 21, 2016
Merged

Update version and changelog for 0.4 #910

merged 4 commits into from
Sep 21, 2016

Conversation

riyazdf
Copy link
Contributor

@riyazdf riyazdf commented Aug 11, 2016

Updated NOTARY_VERSION and the changelog - I did my best to sift through our milestone and issues/PRs to capture the changes. The link for the tag on our changelist won't resolve until the tag is published

@cyli
Copy link
Contributor

cyli commented Aug 11, 2016

Should we also add the bit about changing the import export format from zip to PEM?

@riyazdf
Copy link
Contributor Author

riyazdf commented Aug 11, 2016

@cyli: definitely. Done 👍

@HuKeping
Copy link
Contributor

Are we ready for 0.4 now? I see there's still some issue under 0.4 milestone hasn't been closed yet.

@riyazdf
Copy link
Contributor Author

riyazdf commented Aug 12, 2016

Hi @HuKeping - thanks for checking in! This PR isn't officially releasing 0.4, since we'd be merging into the release candidate branch release/0.4. Once v0.4.0 is ready, we'll release the tag to master.

As for the remaining 0.4 issues - #735 has a PR open and #731 is half-complete (--rootkey flag) and the other half in a PR in progress. We'd like to get both in to a v0.4.X but they may not be critical for an initial RC or v0.4.0.

@riyazdf riyazdf mentioned this pull request Aug 15, 2016
Closed
@HuKeping
Copy link
Contributor

Hi @riyazdf does it make sense also add the relative PR link at the end of each line?

@riyazdf
Copy link
Contributor Author

riyazdf commented Aug 19, 2016

@HuKeping - definitely would be more than happy to!

@cyli cyli added this to the Notary 0.4 milestone Sep 12, 2016
@riyazdf
update NOTARY_VERSION to 0.4
945a7b3 
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
@riyazdf
Update changelog for 0.4
525dc61 
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
@riyazdf
Include PR numbers
f6b2a9b 
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
@riyazdf
Update for notary reset
3fe31dd 
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
cyli
cyli approved these changes Sep 21, 2016
View reviewed changes
Copy link
Contributor

@cyli cyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green! Thank so for keeping this up to date!

endophage
endophage approved these changes Sep 21, 2016
View reviewed changes
Copy link
Contributor

@endophage endophage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riyazdf riyazdf merged commit 4af1728 into release/0.4.0 Sep 21, 2016
@riyazdf riyazdf deleted the 0.4 branch September 21, 2016 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyli cyli cyli approved these changes

@endophage endophage endophage approved these changes

Assignees
No one assigned
Labels
status/0-triage
Projects
None yet
Milestone
Notary 0.4
Development

Successfully merging this pull request may close these issues.
5 participants
@riyazdf @cyli @HuKeping @endophage @GordonTheTurtle