Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog #919

Closed
wants to merge 5 commits into from
Closed

Changelog #919

wants to merge 5 commits into from

Conversation

endophage
Copy link
Contributor

@cyli @riyazdf start on the changelog so we're tracking it somewhere. Pushed this branch to the central repo so we can all add to it as we see fit.

riyazdf and others added 5 commits August 11, 2016 13:22
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
@endophage endophage added this to the Notary 0.4 milestone Aug 15, 2016
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "changelog" git@github.com:docker/notary.git somewhere
$ cd somewhere
$ git rebase -i HEAD~5
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@riyazdf
Copy link
Contributor

riyazdf commented Aug 15, 2016

@endophage: I also started changelog work on #910, if you wanted to move that PR into this one?

@endophage
Copy link
Contributor Author

Ah sorry lol. For some reason totally didn't register. Let's keep going in your PR.

@endophage endophage closed this Aug 15, 2016
@riyazdf riyazdf deleted the changelog branch August 15, 2016 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants