stb_vorbis #defines BUFFER_SIZE which may conflict with other code #1076
Labels
Comments
|
We will probably merge this, but note that stb_vorbis (unlike most other stb libs) is not a header-file library and is meant to be compiled as its own translation unit; #including it into other code is not an intended use case to begin with. |
rygorous
pushed a commit
that referenced
this issue
Jul 4, 2021
|
Fix is merged into dev branch, will be in the next release. |
kcgen
pushed a commit
to dosbox-staging/dosbox-staging
that referenced
this issue
Jul 13, 2021
Fixes issue #1076 (nothings/stb#1076) Imported-from: nothings/stb@3f671b8
kcgen
pushed a commit
to dosbox-staging/dosbox-staging
that referenced
this issue
Jul 13, 2021
Fixes issue #1076 (nothings/stb#1076) Imported-from: nothings/stb@3f671b8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In two locations, stb_vorbis #defines a macro called
BUFFER_SIZE. This is a very generic name that may conflict with other surrounding code. Can this macro be renamed toSTB_BUFFER_SIZE, and maybe also be#undefd afterwards?The text was updated successfully, but these errors were encountered: