Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename BUFFER_SIZE macro to STB_BUFFER_SIZE #1078

Closed
wants to merge 1 commit into from

Conversation

sagamusix
Copy link
Contributor

Avoid conflicts with other code which may use this very generic macro name.

Fixes #1076

icculus pushed a commit to icculus/SDL_sound that referenced this pull request Jun 28, 2021
from a patch by Johannes Schultz submitted to mainstream
at: nothings/stb#1078
icculus pushed a commit to icculus/SDL_sound that referenced this pull request Jun 28, 2021
from a patch by Johannes Schultz submitted to mainstream
at: nothings/stb#1078
icculus pushed a commit to icculus/SDL_sound that referenced this pull request Jun 28, 2021
from a patch by Johannes Schultz submitted to mainstream
at: nothings/stb#1078
icculus pushed a commit to icculus/SDL_sound that referenced this pull request Jun 28, 2021
from a patch by Johannes Schultz submitted to mainstream
at: nothings/stb#1078
@rygorous
Copy link
Collaborator

rygorous commented Jul 4, 2021

LGTM, merged to dev branch, will be in the next release.

@rygorous rygorous added the 5 merged-dev Merged into development branch label Jul 4, 2021
ccawley2011 pushed a commit to ccawley2011/libxmp that referenced this pull request Jul 4, 2021
from a patch by Johannes Schultz submitted to mainstream
at: nothings/stb#1078
@nothings nothings closed this Jul 12, 2021
ccawley2011 pushed a commit to ccawley2011/libxmp that referenced this pull request Jul 12, 2021
from a patch by Johannes Schultz submitted to mainstream
at: nothings/stb#1078
sezero added a commit to libsdl-org/SDL_mixer that referenced this pull request May 21, 2022
- Keeps the original stb_vorbis as intact as possible so
  that future updates from mainstream would be painless.
- Reduces STB_VORBIS_MAX_CHANNELS from 16 to 6 (objections?)
- Adds several missing libm function overrides,
- SDL_mixer now requires SDL >= 2.0.9 because of SDL_exp()
- Fixes slow loads and leaks in start_decoder:
  nothings/stb#1174
- Fixes submap array out-of-bounds indexing bug:
  nothings/stb#1312
- Replace signed overflow clamps with unsigned overflow:
  nothings/stb#1168
- Replaces alloca() usage with setup_malloc() (from libxmp.)
- Fixes '-Wmaybe-uninitialized' warnings in get_seek_page_info:
  nothings/stb#1172
- A minor UBSan fix and suppression:
  nothings/stb#1168
- Fixes signature of dummy realloc() for STB_VORBIS_NO_CRT:
  nothings/stb#1198
- Renames BUFFER_SIZE macro to STB_BUFFER_SIZE:
  nothings/stb#1078
- Pulls in sample-accurate offset patch of Vitaly Novichkov:
  (stb_vorbis_get_playback_sample_offset, because it's used
  in OGG_Tell and OGG_GetSome):
  nothings/stb#1294
  nothings/stb#1295
- Fixes a few warnings here and there in some environments.
- Replaces two dummy '(void) 0' with 'do {} while(0)'
sezero added a commit to libsdl-org/SDL_mixer that referenced this pull request May 21, 2022
- Keeps the original stb_vorbis as intact as possible so
  that future updates from mainstream would be painless.
- Reduces STB_VORBIS_MAX_CHANNELS from 16 to 6 (objections?)
- Adds several missing libm function overrides,
- SDL_mixer now requires SDL >= 2.0.9 because of SDL_exp()
- Fixes slow loads and leaks in start_decoder:
  nothings/stb#1174
- Fixes submap array out-of-bounds indexing bug:
  nothings/stb#1312
- Replace signed overflow clamps with unsigned overflow:
  nothings/stb#1168
- Replaces alloca() usage with setup_malloc() (from libxmp.)
- Fixes '-Wmaybe-uninitialized' warnings in get_seek_page_info:
  nothings/stb#1172
- A minor UBSan fix and suppression:
  nothings/stb#1168
- Fixes signature of dummy realloc() for STB_VORBIS_NO_CRT:
  nothings/stb#1198
- Renames BUFFER_SIZE macro to STB_BUFFER_SIZE:
  nothings/stb#1078
- Pulls in sample-accurate offset patch of Vitaly Novichkov:
  (stb_vorbis_get_playback_sample_offset, because it's used
  in OGG_Tell and OGG_GetSome):
  nothings/stb#1294
  nothings/stb#1295
- Fixes a few warnings here and there in some environments.
- Replaces two dummy '(void) 0' with 'do {} while(0)'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 stb_vorbis 5 merged-dev Merged into development branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stb_vorbis #defines BUFFER_SIZE which may conflict with other code
3 participants