-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build docker images for arm arch #3309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Cliftonz should we utilize depot in someway for this? Also, how this should affect the way we push to GHCR? Or no further action is needed from our side there |
@scopsy Any thoughts on this one? I've been loving the integration of Novu but for m1 mac's its being a blocker as sometimes the API crashes and needs manual reloading |
Would love to have @Cliftonz take a look at this to make sure we are not making the docker files larger and it's backwards compatible 🙏 |
Taking a look at this now |
@DaleWebb @scopsy Following up on this Depot is not currently building ARM containers otherwise it will block all of our builds. I have reached out to support to get this solved hopefully as soon as possible. Otherwise, the local docker build does not seem like any issue other then needing to run |
The issue was with depot waiting for context to be passed in on std in and not timing out. |
@Cliftonz Can we close/merge this PR? |
@jainpawan21 Not yet, I will look over this monday |
@DaleWebb @underfisk I am going to have to delay working on this for the moment. |
Ah no worries, lately I've developed a tool with Playwright that automates the setup which was a thing that wasn't possible with Novu because the SDK always demands an API key, there are no "root/master" credentials which I hope there were. assertion failed [result.value != EEXIST]: VmTracker attempted to allocate existing mapping Let me know once there are some news regarding ARM support as it's starting to become somewhat important for our codebase |
Thanks for letting us know. I will see what I can do shortly. |
are there any updates regarding arm64 support? ❤️ |
Hi @Cliftonz |
Not at this current time, I really hate to do this but we have much higher priorities from the business and reliability side of things. This is definitely a great to have though we do not have the time currently to implement this in our pipeline. |
Closed by PR 5139 |
What change does this PR introduce?
Builds the docker images for arm64 and amd64 architectures using buildkit emulation
Why was this change needed?
Closes #1316
Other information (Screenshots)
nikolaik/python-nodejs:python3.10-nodejs16-alpine
as this couldn't be compiled for arm.