-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARM Architecture Support #5139
ARM Architecture Support #5139
Conversation
…into inf-136-arm-support-for-images # Conflicts: # .github/workflows/dev-deploy-inbound-mail.yml # .github/workflows/dev-deploy-ws.yml # apps/api/package.json # apps/inbound-mail/package.json # apps/worker/package.json # apps/ws/Dockerfile # apps/ws/package.json
❌ Deploy Preview for dev-web-novu failed.
|
@@ -1,5 +1,6 @@ | |||
# start build stage | |||
FROM nikolaik/python-nodejs:python3.10-nodejs20-alpine as builder | |||
FROM node:20-alpine3.19 as builder | |||
RUN apk add g++ make py3-pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test this without python?
I am unsure if we need python in this container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed that python was needed where basic images include python. Also Pawel said that python is used on the build and in some images the ARM architecture build hung without it. I will recheck and let you know 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AliaksandrRyzhou Lets double check this, I know its needed for inbound-mail for sure but I have not seen anything else in the project that needs it.
@LetItRock Are you aware of any build tools that leverage python for our project?
I want to make sure we are only doing what we need to cut build times down as much as possible, but @AliaksandrRyzhou if this takes more then 2 hours to debug lets create a ticket and look at it in the future so we can get this moved through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add this to a ticket
@AliaksandrRyzhou Lets fix the last comment and lets get this merged in
@Cliftonz I've made a quick investigation and found out that we can't build the docker images for the ARM platform without Python. It fails even in the images where Python wasn't installed initially. It looks like some npm packages include native dependencies that need to be compiled during installation. These dependencies might be platform-specific and iinstalling Python might provide a necessary build environment for these native dependencies. |
…into inf-136-arm-support-for-images
Planning to merge February 5th |
I wonder if something has broken this PR, because the OS/Arch tab is no longer present in the built images on ghrc |
@estubmo Please accept our apologies. We decided to change an approach of a building process in a bit, you will see multi-architecture images soon. |
@AliaksandrRyzhou No problem, thanks for your reply. Do you have access to some arm64 tags I could use in the meantime, preferably for the prod images? |
Same issue here. @AliaksandrRyzhou if you have any tag that works on arm, it would be great! thanks |
Any update on this @AliaksandrRyzhou? |
@udleinati @estubmo we have a working production on arm with an old image, i dont know it this helps someone in the meantime: |
@AliaksandrRyzhou still no updates for us? |
@paulwer @AliaksandrRyzhou and I are not working on Novu anymore. This is something that will hopefully be fixed in the next version. @SokratisVidros would you be able to speak to this? |
Currently, we are reshuffling the roadmap and aiming at a stable, multi-architecture, Novu V2 docker release in early September. |
@SokratisVidros is this considdered in the upcomming v2 release? |
@merrcury ☝️ |
@merrcury @SokratisVidros does it help, when I open an other issue for better clarity on this topic or are there further informations for us now? |
Hey, @paulwer We are working on V2 release. We will see if we will be able to solve this with that. For community Announcement, Please check discord. Last Announcement . Otherwise, I'll separately add this to our roadmap. Stay Tuned |
What change does this PR introduce?
These changes will allow us to build docker images for ARM platforms too.
Why was this change needed?
Other information (Screenshots)
Example of what we expect to see: