fix: change default value to true for critical switch #4882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-2902 bug: new workflow is critical by default
What?Critical workflow overrides above the workflow and subscriber preference Why? (Context)Steps to reproduce:-
Definition of Done It should not be critical by default as a new user is not aware about critical concept. User get confused why subscriber preference is not working? |
jainpawan21
commented
Nov 21, 2023
| @@ -112,7 +112,7 @@ const defaultValues: IForm = { | |||
| description: '', | |||
| identifier: '', | |||
| tags: [], | |||
| critical: false, | |||
There was a problem hiding this comment.
changed default value to true so that switch button for critical option is on and workflow is created non-critical
jainpawan21
commented
Nov 21, 2023
| @@ -49,6 +49,7 @@ export function ChannelPreference() { | |||
| borderRadius: 8, | |||
| }} | |||
| position="apart" | |||
| key={key} | |||
There was a problem hiding this comment.
Added this key filed to remove console unique key react error
scopsy
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Closes #4647
Why was this change needed?
Other information (Screenshots)