Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change default value to true for critical switch #4882

Merged
merged 2 commits into from
Nov 30, 2023
Merged

fix: change default value to true for critical switch #4882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e342d56
fix: change default value to true for switch
jainpawan21 Nov 21, 2023
ee9d304
Merge branch 'next' into NV-2902
scopsy Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web/src/pages/templates/components/TemplateEditorFormProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ const defaultValues: IForm = {
description: '',
identifier: '',
tags: [],
critical: false,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed default value to true so that switch button for critical option is on and workflow is created non-critical

critical: true,
steps: [],
preferenceSettings: {
email: true,
Expand Down
3 changes: 2 additions & 1 deletion apps/web/src/pages/templates/components/notification-setting-form/TemplatePreference.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export function ChannelPreference() {
borderRadius: 8,
}}
position="apart"
key={key}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this key filed to remove console unique key react error

>
<Text>{<ChannelTitle channel={key as ChannelTypeEnum} />}</Text>
<div>
Expand Down Expand Up @@ -76,7 +77,7 @@ export function CriticalPreference() {
return (
<Controller
name="critical"
defaultValue={false}
defaultValue={true}
control={control}
render={({ field }) => {
return (
Expand Down
Loading